Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tf hotfix #3399

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Tf hotfix #3399

merged 3 commits into from
Dec 3, 2024

Conversation

adam3smith
Copy link
Collaborator

closes #3398

@adam3smith
Copy link
Collaborator Author

@AbeJellinek 3 reports on the forum within a day of this, would be great to merge asap

@adam3smith
Copy link
Collaborator Author

Thanks I took out the m flag. I don't think we need/want the linebreak -- the m flag was just a leftover.
FWIW, even with m flag, this would never match valid regex because there would be a comma before the first closing bracket.

@AbeJellinek AbeJellinek merged commit a2bd2f2 into zotero:master Dec 3, 2024
1 check passed
@AbeJellinek
Copy link
Member

Thanks, yeah, forgot that there's a comma after the citekey so it's fine either way.

Seems like GH PRs are being flakey, but should be merged in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbeJellinek AbeJellinek AbeJellinek left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T&F Import broken because of broken bibTeX
2 participants
@adam3smith @AbeJellinek