-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluesky translator #3400
base: master
Are you sure you want to change the base?
Bluesky translator #3400
Conversation
The Bsky API in fact returns all replies, which is a non-starter for popular posts which may have hundreds or thousands – we don't want to store a separate note for each. Instead, we now store a note with the number of direct replies at the time of storage, as an ISO datetime.
Also remove newlines and extra whitespace
Hi @AbeJellinek, could I please request a merge/review of this PR? The current translator-less items saved for Bluesky are not great. @urschrei, my only other suggestion is to just label these items as "Post" instead of "Skeet", which seems a rather colloquial term (and also use "Post" for the Twitter and Mastodon translators for consistency). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments/suggestions.
Any error in the debug log? |
Looks like Safari-specific CORS policy errors CORS errors from debug log
|
I've made the suggested changes: please lmk if the regex changes in
|
This adds the ability to save individual Bluesky posts. Details:
The translator isn't working on Safari / Safari Technology Preview (I tested successfully with Scaffold, Firefox, and Chrome). I can't see any reason for this besides an issue on Safari's side.