Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cancel button to undo unwanted save session #512

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Sep 18, 2024

  1. add cancel button to undo unwanted saving session

    - Added cancel button to undo saving of items in case
    it was started by mistake
    - If none of /connector/save* endpoints were called yet,
    the button will just exit at saveItems.
    - If the connector server has been engaged, hit /connector/cancel
    to tell the server to undo this session
    - After cancel button is clicked, the connector window is hidden
    - Minor style tweaks to fit the cancel buttons on the same
    row as tags input and done button
    abaevbog committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ba1aea1 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. initial styling of buttons in header

    - place the Done and Cancel buttons in the header
    - minor re-styling of all buttons in the header
    so they look more uniform
    - added new svg-s for relevant buttons, deleted unused files
    - disclosure button will flip the up/down on each click
    - cancel and done button will expand on hover and
    change the icon for textual label
    - made the entire dialog a bit wider
    - do not set explicit height of the dialog using scrollHeight
    anymore, just let it expand as much as it needs unless
    it leaves outside of the bounds of the screen
    - made the dialog a flexbox so that the progress box
    with items can expand as much as it needs and then
    become scrollable if we run out of space
    abaevbog committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c0ccb49 View commit details
    Browse the repository at this point in the history
  2. fill=black for chevron

    abaevbog committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3dc4551 View commit details
    Browse the repository at this point in the history
  3. no done btn unless target selector expanded

    and no margin after the last visible button in header
    abaevbog committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3168257 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    4a537eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f6eb01 View commit details
    Browse the repository at this point in the history
  3. only show cancel button if the client supports it

    Do not show cancel button if the client did not return
    supportsSaveCancelling from /ping or if we are saving
    to web library.
    abaevbog committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f27f4a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f7a9859 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. this.state.targets to determine if saving to web

    Instead of an extra checkOnline call
    abaevbog committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3f7137a View commit details
    Browse the repository at this point in the history
  2. fix "Saving to zotero.org" not appearing in header

    Fixed bug where an error would be thrown in the
    end of changeHeadline if there is no target and the
    header would not get set.
    abaevbog committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f78fa67 View commit details
    Browse the repository at this point in the history