Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prevent base profile name collisions by default on new configuration files #3020

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Jul 25, 2024

Proposed changes

Added global property to ConfigBuilder API call, causing base profiles created in a new team configuration file to possess the name global_base for Global configuration files, or project_base for Project configuration files. Adds tests to assert this behavior is functioning properly.

Release Notes

Milestone: v3.0.0

Changelog: Enhancement: Changed default base profile naming scheme in newly generated configuration files to prevent name and property conflicts between Global and Project profiles #2682

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (266a2d4) to head (7cbcf89).
Report is 3 commits behind head on ext-not.

Additional details and impacted files
@@             Coverage Diff             @@
##           ext-not    #3020      +/-   ##
===========================================
+ Coverage    92.76%   92.78%   +0.02%     
===========================================
  Files          107      107              
  Lines        10912    10912              
  Branches      2282     2360      +78     
===========================================
+ Hits         10122    10125       +3     
+ Misses         788      785       -3     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn requested a review from anaxceron July 26, 2024 12:18
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
30.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @awharn

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Andrew for the enhancement and for adding tests for the global parameter 😋

@t1m0thyj t1m0thyj merged commit ff01a69 into ext-not Jul 26, 2024
16 of 17 checks passed
@t1m0thyj t1m0thyj deleted the awharn/support-updated-cli-sdks branch July 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants