-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prevent base profile name collisions by default on new configuration files #3020
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
…ated-cli-sdks Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ext-not #3020 +/- ##
===========================================
+ Coverage 92.76% 92.78% +0.02%
===========================================
Files 107 107
Lines 10912 10912
Branches 2282 2360 +78
===========================================
+ Hits 10122 10125 +3
+ Misses 788 785 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn!
Signed-off-by: Andrew W. Harn <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @awharn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Andrew for the enhancement and for adding tests for the global
parameter 😋
Proposed changes
Added global property to ConfigBuilder API call, causing base profiles created in a new team configuration file to possess the name
global_base
for Global configuration files, orproject_base
for Project configuration files. Adds tests to assert this behavior is functioning properly.Release Notes
Milestone: v3.0.0
Changelog: Enhancement: Changed default base profile naming scheme in newly generated configuration files to prevent name and property conflicts between Global and Project profiles #2682
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments