-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Table view framework and related facilities #3027
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of weviews
comments, many more to come. 😋
Code is LGTM so far! 🥳
The main reason for requesting changes was addressed by Trae's explanation on packages/zowe-explorer-api/src/vscode/ui/utils/TableBuilder.ts
😋
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get some minor changes when running the prepublish script.
but aside from that, and all the other comments (which where mostly dumb questions for my own understanding)...
I do believe this LGTMerge! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update the changelog in the zFTP VSCE package since this was the only change that happened. 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @traeok! Left a few comments
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition @traeok, I may be misunderstanding the PR but I don't see anything populated when selecting the Zowe Resources. I am also encountering issues with Job search in the tree for owner with my HLQ * * but can search by job id or when selecting the hyperlink after submitting. Will have to test to see if this is on next to and not just with PR.
testing on mac m1
Hi @JillieBeanSim, sorry for the confusion - this PR implements the table classes, logic and related facilities. To avoid a bunch of changed files for reviewers, I have been working on the jobs table view in a separate branch. We don't have a GitHub issue specific for the table framework, but I've attached it to the "jobs table" issue as it implements the generic components that will be used for it. I'll be creating a PR for the jobs table some time today/tomorrow 😁 As for the issues with job search, this is likely an existing issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @traeok for quick response, I found my issue with jobs search I mentioned so no worries for that, it was with my config. Code looks good and can address any issues with follow up PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
@@ -11,18 +11,22 @@ | |||
"preview": "vite preview", | |||
"fresh-clone": "pnpm clean && rimraf node_modules", | |||
"clean": "rimraf dist || true", | |||
"package": "echo \"webviews: nothing to package.\"", | |||
"package": "node -e \"fs.accessSync(path.join(__dirname, 'dist'))\" && echo \"webviews: nothing to package.\" || pnpm build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change required, but we may be able to use a relative path here since I think npm scripts already run in the context of the current directory 😋
"package": "node -e \"fs.accessSync(path.join(__dirname, 'dist'))\" && echo \"webviews: nothing to package.\" || pnpm build", | |
"package": "node -e \"fs.accessSync('dist')\" && echo \"webviews: nothing to package.\" || pnpm build", |
Proposed changes
Table.View
)TableBuilder
)TableMediator
)TableViewProvider
Unrelated changes
zedc
forzip_path
being unusedNote that some slight adjustments to this framework may occur to fully support the tabular jobs view in a separate branch. This branch only contains the framework and data structures for making, exposing and rendering generic tables.
Dev. documentation on wiki
Release Notes
Milestone: vNext
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment