Fix Coverity code smells in Profiles.ts

[t1m0thyj]

Proposed changes

Fixes 2 code smells detected by Coverity for nullable values

Release Notes

Milestone:

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (6808cd9) to head (61beb69).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
+ Coverage   93.45%   93.47%   +0.01%     
==========================================
  Files         104      104              
  Lines       10986    10984       -2     
  Branches     2414     2311     -103     
==========================================
  Hits        10267    10267              
+ Misses        718      716       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

This LGTM, thanks Timothy -- just a quick question regarding the original parameter type: Do we know why node was previously marked as optional? If we don't expect the function to be called without one, then this change is good to go - I was mostly curious to know if you had any insight on that 😋

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[t1m0thyj]

This LGTM, thanks Timothy -- just a quick question regarding the original parameter type: Do we know why node was previously marked as optional? If we don't expect the function to be called without one, then this change is good to go - I was mostly curious to know if you had any insight on that 😋

I believe it may have been copied from other methods in Profiles.ts where the parameters are an optional node? or label?. But the only usage of this function is in the "Manage Profile" quickpick where a node should be defined.

[zFernand0]

LGTM! 😋
not sure why the node was optional in the first place 😋