Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust imports to main #3036

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Adjust imports to main #3036

merged 2 commits into from
Aug 2, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Aug 1, 2024

Proposed changes

See build breaking in some instances, this PR addresses that removing imports from Zowe SDKs and point the import to the already used zowe/cli dependency. Full migration to the SDKs is in the v3 work.

Release Notes

Milestone: 2.18.0

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added this to the v2.18.0 milestone Aug 1, 2024
@JillieBeanSim JillieBeanSim self-assigned this Aug 1, 2024
@JillieBeanSim JillieBeanSim marked this pull request as ready for review August 1, 2024 18:12
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (dcfdc8b) to head (79d4f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         104      104           
  Lines       10984    10985    +1     
  Branches     2396     2314   -82     
=======================================
+ Hits        10267    10268    +1     
  Misses        716      716           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Aug 1, 2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for the quick fix. 🙏🏽

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JillieBeanSim!

@JillieBeanSim JillieBeanSim merged commit c6632cf into main Aug 2, 2024
27 checks passed
@JillieBeanSim JillieBeanSim deleted the fix-imports branch August 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants