-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce integrated terminal #3079
Open
zFernand0
wants to merge
65
commits into
main
Choose a base branch
from
feat/int-term
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
0f14050
chore: remove code duplication in preparation to handling integrated …
zFernand0 73f5814
chore: done consolidating, fixing unit test before continuing :yum:
zFernand0 ee95d66
tests: fix unit tests and address any missing checks :yum:
zFernand0 48abeef
tests: fix the rest of the unit tests :yum:
zFernand0 43d6863
l10n: update strings :yum:
zFernand0 beba0c4
chore: Add zoweTerminal :yum:
zFernand0 d3b5975
chore: finalize ZoweTerminal implementation :yum:
zFernand0 4f7dd21
chore: add actual z/os behavior :yum:
zFernand0 451c49b
chore: add missing license header
zFernand0 978ff99
tests: fix unit tests assuming we are not using integrated terminals
zFernand0 8b2d310
feat: initial addition of zowe commands to edit History webview
zFernand0 ee12695
fix: done with core terminal issues
zFernand0 859807c
tests: fix unit tests for now :yum:
zFernand0 6d49d02
fix remainig unit tests
zFernand0 65c8e24
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 04927a3
fix: remove circular references
zFernand0 96a8d25
test: add small unit test :yum:
zFernand0 257254b
test: add more unit testws to bump patch coverage
zFernand0 819e742
chore: more unit tests
zFernand0 3898c54
Merge branch 'main' into feat/int-term
zFernand0 ef41fcf
fix: edge case when processing double-byte characters
zFernand0 93b6c30
fix handle unicode characters
zFernand0 52eb208
fix: error handling for failing responses from the server
zFernand0 062327f
Merge branch 'main' into feat/int-term
zFernand0 20c313a
Update packages/zowe-explorer/src/commands/UnixCommandHandler.ts
zFernand0 7f1375e
test: update test to reflect less operation cancelled notifications :…
zFernand0 54c2f89
review: updates based on feedback :yum:
zFernand0 612473d
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 6df816c
review: localize strings in package.json
zFernand0 b6170fa
Merge branch 'main' into feat/int-term
JillieBeanSim 75d1386
fix: profile selection cached between commands via the palette
zFernand0 882db9a
fix: iTerm setting not working from the workspace scope :yum:
zFernand0 1ba492a
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 7833f74
fix: make profile validation consistent amonogst all cmdTypes
zFernand0 88e064b
review: add validation of SSH porfiles:
zFernand0 33294c9
chore: multiple fixes (see below)
zFernand0 986fbaf
feat: separated commands history :yum:
zFernand0 e181481
fix: Greyout entry text in iTerms
zFernand0 e618b14
review: fix unit test after adding validation
zFernand0 75a6d03
chore: update changelog
zFernand0 7f18310
review: updated sdk and removed ssh2 lazy-loading
zFernand0 85696d1
chore: update unit tests for new APIs
zFernand0 931ed3f
chore: update dependencies across the board
zFernand0 3311857
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 133276e
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 ccc9f48
chore: fix lint issues and update changelogs
zFernand0 a18f7f6
review: fis unit tests
zFernand0 230e933
chore: cleanup ssh profile validation logic
zFernand0 172cfe5
review: update changelog
zFernand0 f578724
review: add italic to :clear command
zFernand0 dc3d748
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 50fd881
review: address lint issues
zFernand0 f5546a6
review: Address delete key, and cancel operations
zFernand0 5e5242f
review: revert typecript update
zFernand0 725e369
review: remove redundant logs
zFernand0 f839d0e
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 09e0ce2
review: fix delete key with moving cursor across emojis and special c…
zFernand0 b707bdb
Merge branch 'main' of https://github.com/zowe/zowe-explorer-vscode i…
zFernand0 05a892c
review: fix oversight of moving to charArray
zFernand0 2716e21
review: handle home and end keys
zFernand0 a9247fc
review: address home and end key
zFernand0 d58c416
review: display non printable characters
zFernand0 f4d60dd
Merge branch 'main' into feat/int-term
zFernand0 4d498c4
review: fix modifier keys and add intuitive control+C exit
zFernand0 c998f8d
review: bump test coverage of the zowe terminal
zFernand0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,6 @@ | |
import * as vscode from "vscode"; | ||
import * as imperative from "@zowe/imperative"; | ||
import { IZoweTreeNode } from "./IZoweTreeNode"; | ||
import type { BaseProvider } from "../fs/BaseProvider"; | ||
|
||
/** | ||
* Common implementation of functions and methods associated with the | ||
|
@@ -98,9 +97,9 @@ export class ZoweTreeNode extends vscode.TreeItem { | |
/** | ||
* Sets the imperative.IProfileLoaded profile for this node to the one chosen in parameters. | ||
* | ||
* @param {imperative.IProfileLoaded} The profile you will set the node to use | ||
* @param {imperative.IProfileLoaded} aProfile The profile you will set the node to use | ||
*/ | ||
public setProfileToChoice(aProfile: imperative.IProfileLoaded, fsProvider?: BaseProvider): void { | ||
public setProfileToChoice(aProfile: imperative.IProfileLoaded): void { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a breaking change in ZE API? Or is it ok since the param was optional/unused? |
||
// Don't reassign profile if its already defined, as we want to keep the reference valid for other nodes and filesystems | ||
this.profile = Object.assign(this.profile ?? {}, aProfile); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the old and new method have the same function signature, curious whether we prefer this approach of adding a new method, or adding an optional boolean param to the existing method to change its behavior?