Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows and deps for technical currency #3373

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Dec 24, 2024

Proposed changes

We can switch back to ubuntu-latest in our workflows now as GitHub has fixed the issues with the Ubuntu 24 image 😋

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (aea6d92) to head (397d08b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3373   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         117      117           
  Lines       12277    12277           
  Branches     2822     2818    -4     
=======================================
  Hits        11439    11439           
  Misses        837      837           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Dec 24, 2024
@t1m0thyj t1m0thyj marked this pull request as ready for review December 24, 2024 14:41
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0
Copy link
Member

no changelog required, merging!

@zFernand0 zFernand0 merged commit 05721c3 into main Jan 2, 2025
27 of 28 checks passed
@zFernand0 zFernand0 deleted the chore/update-workflows-and-deps branch January 2, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/M
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants