Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain missing nodeJS error better (v2) #4124

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented Jan 9, 2025

If you configure "node.home" wrong, you will likely encounter

  • Output:
    node: read_yaml 10: /zowe-release-2.18.0/bin/commands/init/certificate/index.sh 20: .: zwecli_process_command 4: /zowe-release-2.18.0/bin/zwe 98: FSUM7351 not found
    Error ZWEL0157E: Zowe dataset prefix (zowe.setup.dataset.prefix) is not defined in Zowe YAML configuration file.

This has time and time again caused people to believe the problem is "zowe.setup.dataset.prefix" when it isnt.

With this change, it will now print:

Error ZWEL0319E: NodeJS required but not found. Errors such as ZWEL0157E may occur as a result.
The value 'node.home' in the Zowe YAML is not correct. Set it to the parent directory of 'bin/node'."
For example, if NodeJS is at '/opt/nodejs/bin/node', then set 'node.home' to '/opt/nodejs'.

  • Output:
    node: read_yaml 10: /zowe-release-2.18.0/bin/commands/init/certificate/index.sh 20: .: zwecli_process_command 4: /zowe-release-2.18.0/bin/zwe 98: FSUM7351 not found

Error ZWEL0157E: Zowe dataset prefix (zowe.setup.dataset.prefix) is not defined in Zowe YAML configuration file.

ZWEL0157E still is printed, because of how this read_yaml function is called, doing an exit wont stop execution. So, the first message at least warns about the second.

Fixes #3426 for v2

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Copy link

github-actions bot commented Jan 9, 2025

build 6701 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12690851938

Copy link

github-actions bot commented Jan 9, 2025

build 6699 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12690839888

Copy link

github-actions bot commented Jan 9, 2025

Test workflow 5902 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.18.1-PR-4124/zowe-2.18.1-pr-4124-6701-20250109133423.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12690974442

Copy link

github-actions bot commented Jan 9, 2025

Test workflow 5903 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.18.1-PR-4124/zowe-2.18.1-pr-4124-6699-20250109133554.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12691002694

Signed-off-by: 1000TurquoisePogs <[email protected]>
Copy link

github-actions bot commented Jan 9, 2025

build 6702 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12691610124

Copy link

github-actions bot commented Jan 9, 2025

Test workflow 5904 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.18.1-PR-4124/zowe-2.18.1-pr-4124-6702-20250109141644.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12691725761

Copy link

github-actions bot commented Jan 9, 2025

build 6706 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12692082590

Copy link

github-actions bot commented Jan 9, 2025

Test workflow 5908 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.18.1-PR-4124/zowe-2.18.1-pr-4124-6706-20250109144434.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12692248553

@1000TurquoisePogs 1000TurquoisePogs merged commit 7a0543c into v2.x/staging Jan 9, 2025
12 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the bugfix/v2/explain-ZWEL0157E branch January 9, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants