Initial prototype implementation #8

msujew · 2024-09-04T12:12:15Z

This is an initial implementation of the PL/I language server using Langium. It supports most (as far as we can tell) of the base language. Missing prominent features:

Macro language (preprocessor)
Compiler flags

packages/extension/src/extension/builtin-files.ts

packages/language/src/documentation.ts/pli-documentation-provider.ts

packages/language/src/parser/pli-grammar.ts

scripts/merge-tmlanguage.mjs

asatklichov

Code is nice 👍, now will check tests and do some testing

package.json

packages/extension/src/extension/builtin-files.ts

packages/language/src/parser/pli-lexer.ts

vitest.config.ts

KUGDev · 2024-09-06T10:52:38Z

LGTM, works the same way in IntelliJ IDEA

VitGottwald · 2024-09-09T09:20:00Z

Please, add .nvmrc file with expected node version (e.g. v20.17.0).

packages/language/src/pli.langium

packages/extension/.vscodeignore

.vscode/launch.json

VitGottwald · 2024-09-17T11:26:39Z

Can we replace pl-one everywhere in the code and package.json(s) with pli to have single word language name like we do for the other extensions (hlasm, cobol, rexx, jcl, ...)?

code_samples/CHART.pli

code_samples/MACROS.pli

code_samples/PLI0002.pli

packages/extension/package.json

asatklichov · 2024-10-09T13:00:38Z

adding CI build, vsix gen, and browser exec
dummy validation and semantic class

packages/extension/README.md

packages/language/README.md

KUGDev · 2024-11-21T12:18:45Z

From the repo perspective, it would be better to separate the actual solution between different folders. The implementation is intended to be supported both in VS Code and IntelliJ IDEA. Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future

azatsatklichov · 2024-11-21T12:39:38Z

From the repo perspective, it would be better to separate the actual solution between different folders. The implementation is intended to be supported both in VS Code and IntelliJ IDEA. Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future

It is a good idea, I agree.

.vscode/launch.json

.github/workflows/ci.yml

azatsatklichov

💯

package.json

packages/language/src/validation/utils.ts

packages/language/src/workspace/pli-builtin-functions.ts

packages/language/test/validation-messages/errors.test.ts

...s/IBM1747IS-Function-cannot-be-used-before-the-functions-descriptor-list-has-been-scanned.ts

...IBM1388IE-NODESCRIPTOR-attribute-is-invalid-when-any-parameter-has-NONCONNECTED-attribute.ts

...nguage/src/validation/messages/IBM1324IE-name-occurs-more-than-once-within-exports-clause.ts

packages/language/src/validation/messages/IBM1295IE-sole-bound-specified.ts

.github/workflows/ci.yml

Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>

VitGottwald · 2025-01-26T11:12:15Z

.vscode/launch.json

+            "sourceMaps": true,
+            "outFiles": [
+                "${workspaceFolder}/packages/language/out/**/*.js",
+                "${workspaceFolder}/packages/vscode-extension/out/**/*.js"


Suggested change

"${workspaceFolder}/packages/vscode-extension/out/**/*.js"

"${workspaceFolder}/packages/vscode-extension/out/**/*.cjs"

The generated main file is main.cjs and with the current pattern it does not get matched and debugging does not work.

It makes sense, but I'm nevertheless able to debug both the language server and the VS Code extension. Have you had trouble debugging the language server? Make sure to run the Attach to Language Server configuration after the language server has started up (i.e. after opening a .pli file).

packages/language/src/pli.langium

Signed-off-by: Mark Sujew <[email protected]>

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/extension/src/extension/builtin-files.ts Outdated Show resolved Hide resolved

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/language/src/documentation.ts/pli-documentation-provider.ts Outdated Show resolved Hide resolved

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/language/src/parser/pli-grammar.ts Outdated Show resolved Hide resolved

scripts/merge-tmlanguage.mjs Outdated Show resolved Hide resolved

asatklichov self-assigned this Sep 4, 2024

msujew force-pushed the feature/langium-project branch from b06d804 to 9b0ecae Compare September 4, 2024 13:03

asatklichov reviewed Sep 5, 2024

View reviewed changes

package.json Show resolved Hide resolved

packages/extension/src/extension/builtin-files.ts Outdated Show resolved Hide resolved

packages/language/src/parser/pli-lexer.ts Outdated Show resolved Hide resolved

vitest.config.ts Show resolved Hide resolved

KUGDev self-requested a review September 5, 2024 18:36

KUGDev approved these changes Sep 6, 2024

View reviewed changes

asatklichov reviewed Sep 12, 2024

View reviewed changes

packages/language/src/pli.langium Outdated Show resolved Hide resolved

VitGottwald reviewed Sep 17, 2024

View reviewed changes

packages/extension/.vscodeignore Outdated Show resolved Hide resolved

VitGottwald reviewed Sep 17, 2024

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/CHART.pli Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/MACROS.pli Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/PLI0002.pli Outdated Show resolved Hide resolved

VitGottwald reviewed Sep 18, 2024

View reviewed changes

packages/extension/package.json Outdated Show resolved Hide resolved

msujew force-pushed the feature/langium-project branch 7 times, most recently from 8aa2a54 to a6e1b12 Compare November 18, 2024 13:20

azatsatklichov reviewed Nov 20, 2024

View reviewed changes

packages/extension/README.md Outdated Show resolved Hide resolved

packages/language/README.md Outdated Show resolved Hide resolved

KUGDev self-requested a review November 21, 2024 12:14

msujew force-pushed the feature/langium-project branch from cfe3f94 to d5bf1a6 Compare November 21, 2024 16:23

KUGDev reviewed Nov 22, 2024

View reviewed changes

.vscode/launch.json Show resolved Hide resolved

KUGDev reviewed Nov 22, 2024

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

azatsatklichov approved these changes Nov 26, 2024

View reviewed changes

msujew force-pushed the feature/langium-project branch 2 times, most recently from 1f0d1c2 to cfcd5bf Compare November 26, 2024 17:37

VitGottwald reviewed Dec 4, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

msujew force-pushed the feature/langium-project branch from cfcd5bf to 6b5d434 Compare December 11, 2024 13:19

msujew force-pushed the feature/langium-project branch 3 times, most recently from aaae68e to 183a00e Compare January 15, 2025 15:26

msujew mentioned this pull request Jan 15, 2025

fix: Fix failing test imports TypeFox/zowe-pli-language-support#10

Closed

KUGDev approved these changes Jan 16, 2025

View reviewed changes

asatklichov approved these changes Jan 16, 2025

View reviewed changes

msujew force-pushed the feature/langium-project branch 2 times, most recently from 91e9352 to 4e07d32 Compare January 16, 2025 13:19

VitGottwald reviewed Jan 20, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

VitGottwald reviewed Jan 20, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Prototype implementation of PL/I

279a71d

Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>

msujew force-pushed the feature/langium-project branch from 4e07d32 to 279a71d Compare January 20, 2025 13:07

msujew requested a review from VitGottwald January 20, 2025 13:08

msujew mentioned this pull request Jan 22, 2025

[feature] Support static syntax highlighting via textmate #23

Open

VitGottwald reviewed Jan 26, 2025

View reviewed changes

packages/language/src/pli.langium Show resolved Hide resolved

VitGottwald mentioned this pull request Jan 26, 2025

Support NAMES compiler option #30

Open

msujew added 3 commits January 27, 2025 13:29

Add prettier

064e418

Signed-off-by: Mark Sujew <[email protected]>

Fix launch config

ff1a4e8

Signed-off-by: Mark Sujew <[email protected]>

Remove eslint

8bc5e21

Signed-off-by: Mark Sujew <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial prototype implementation #8

Initial prototype implementation #8

msujew commented Sep 4, 2024

asatklichov left a comment

KUGDev commented Sep 6, 2024

VitGottwald commented Sep 9, 2024

VitGottwald commented Sep 17, 2024

asatklichov commented Oct 9, 2024

KUGDev commented Nov 21, 2024

azatsatklichov commented Nov 21, 2024

azatsatklichov left a comment

VitGottwald Jan 26, 2025

msujew Jan 27, 2025

	"${workspaceFolder}/packages/vscode-extension/out/*/.js"
	"${workspaceFolder}/packages/vscode-extension/out/*/.cjs"

Initial prototype implementation #8

Are you sure you want to change the base?

Initial prototype implementation #8

Conversation

msujew commented Sep 4, 2024

asatklichov left a comment

Choose a reason for hiding this comment

KUGDev commented Sep 6, 2024

VitGottwald commented Sep 9, 2024

VitGottwald commented Sep 17, 2024

asatklichov commented Oct 9, 2024

KUGDev commented Nov 21, 2024

azatsatklichov commented Nov 21, 2024

azatsatklichov left a comment

Choose a reason for hiding this comment

VitGottwald Jan 26, 2025

Choose a reason for hiding this comment

msujew Jan 27, 2025

Choose a reason for hiding this comment