-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add aioodbc
driver support
#163
base: main
Are you sure you want to change the base?
Conversation
thanks for the PR! looks like you just need to run a |
fixed :) |
hm seems like the bigquery creds are having issues. I'll have to have a look when I have some time. |
taking a look at this today |
i just merged #164 this PR which updates the deps and splits the tests out by DBMS. Bigquery issues should be fixed now, but if it fails only on that test, I'm fine merging anyway. Only thing you will need to change once you merge is adding the marker to your test module for the new driver and adding the extra to to the GHA poetry install. Happy to help if you run into issues. |
would you also mind updating the docs for the other db's that aiodbc supports that its available? Just noticed you can specify the driver for different ones. We would probably want to add tests for each in that case as well |
Not at all, but I can start working on this in 2 weeks at the earliest, as I'm away from home right now. |
no problem, I can try to help out if I have the time |
just just bumping this - something you think you'll be able to finish up? |
Hi, sorry for the slight delay :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
===========================================
- Coverage 100.00% 95.15% -4.85%
===========================================
Files 21 23 +2
Lines 582 619 +37
Branches 100 109 +9
===========================================
+ Hits 582 589 +7
- Misses 0 28 +28
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi, this PR adds support for aioodbc driver. Main goal was to use async with mssql.
It also includes tests (
test_mssql/test_aioodbc.py
- based ontest_aiopg.py
) and documentation.On a side note I updated codecov from 2.1.12 to 2.1.13 in order to run tests, because the former was not available on PyPi.