Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] execute autocode from maven #531

Open
wants to merge 5 commits into
base: XML-autocoder
Choose a base branch
from

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Feb 12, 2019

As discussed in #527 . This is an early prototype to gather feedback.
The commits are structured as follows:

  1. Delete all generated code, to make it easier to exclude from review
  2. Should probably be applied to master right away.
  3. The logic of the change.
  • Generated source code discovery works in IDEA, eclipse would have to be validated.

Caveats:

  • Currently only supports the base library. The dongle generation is possible as well. Maybe a dedicated mojo per project or via configurations, if they are similar enough.
  • Only maven (no gradle). Is there a reason for two build systems?
  • Executes the generation twice. (once triggered by the maven-source-plugin, may be disabled)

@cdjackson
Copy link
Member

Thanks @t-8ch . I've not looked over this yet as the changes are extensive. I assume that the real changes are only to the POM? Is it possible to leave the existing code included in the repo for now, or does this not work for some reason?

@cdjackson
Copy link
Member

I also note that the build seems to be failing (according the to LGTM CI anyway)...

@t-8ch
Copy link
Contributor Author

t-8ch commented Feb 12, 2019

You should be able to ignore the first commit completely.
I will take a look at the build.

@t-8ch
Copy link
Contributor Author

t-8ch commented Feb 12, 2019

Ah, LGTM uses gradle. Is there an inherent reason for both build systems?

@cdjackson
Copy link
Member

cdjackson commented Feb 12, 2019 via email

@t-8ch
Copy link
Contributor Author

t-8ch commented Feb 12, 2019

Hm, shouldn't users only consume the .jar file?
It shouldn't matter how it is generated.

@cdjackson
Copy link
Member

cdjackson commented Feb 12, 2019 via email

@t-8ch
Copy link
Contributor Author

t-8ch commented Feb 14, 2019

I will see how it can support both

@stale
Copy link

stale bot commented Oct 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 6, 2019
@cdjackson cdjackson added the pinned Will not be closed, even if stale label Oct 6, 2019
@stale stale bot removed the wontfix label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Will not be closed, even if stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants