fix: prevent ERR_OUT_OF_RANGE errors when reading messageSize from bu…

…ffer (adelsz#571)
zth · Apr 27, 2024 · fbe031e · fbe031e
1 parent 4adb2b5
commit fbe031e
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/packages/wire/src/protocol.ts b/packages/wire/src/protocol.ts
@@ -112,6 +112,16 @@ export const parseMessage = <Params extends object>(
   messageOffset: number = 0,
 ): ParseResult<Params> => {
   let bufferOffset = messageOffset;
+
+  // Check if we have enough data to read the indicator and message size
+  // The + 5 is made up of 1 byte for readInt8 and 4 bytes for readUInt32BE
+  if (bufferOffset + 5 > buf.length) {
+    return {
+      type: "IncompleteMessageError",
+      messageName: message.name,
+    };
+  }
+
   const indicator = buf.readInt8(bufferOffset);
   const expectedIndicator = message.indicator.charCodeAt(0);
   const isUnexpectedErrorMessage =