-
Notifications
You must be signed in to change notification settings - Fork 160
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
inbox [nfc]: Cut superfluous StickyHeaderItems on individual conversa…
…tions These were never getting consulted, because these aren't entire items of the enclosing list view; rather the items are the whole sections, i.e. either a whole stream or all DMs. Because they weren't doing anything, they're confusing for understanding how this code works and making changes to it. I think this happened because in an early draft of #381, the list-view items were individual conversations. That's the arrangement that would be better for performance/smoothness reasons anyway, but it won't work until we make some changes to the sticky_header library; see #389. When we go to do #389, we can always add these StickyHeaderItem widgets back.
- Loading branch information
1 parent
5421518
commit ebff35f
Showing
1 changed file
with
54 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters