home: Sort leading emoji first in channel names #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Dec 30, 2024
lakshya1goel
force-pushed
the
issue1202
branch
from
6e0e1f0 to
46ac2f3
Compare
|
Hello, @chrisbobbe I have done the required changes. Please have a look and let me know if anything else is required. |
|
Hi @chrisbobbe @PIG208 |
chrisbobbe
reviewed
Jan 17, 2025
lakshya1goel
force-pushed
the
issue1202
branch
from
46ac2f3 to
6167d68
Compare
Update the channel sorting logic to match the channels order of web by putting emoji-prefixed channels first. Fixes: zulip#1202
lakshya1goel
force-pushed
the
issue1202
branch
from
6167d68 to
0c567a3
Compare
|
Thanks for the detailed review. I have made the required changes. |
|
Pushed the changes atop #1290 for the sake of CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the channel sorting logic to ensure streams with leading emojis in their names are listed above those without emojis. The updated sorting respects pinned, muted, and unmuted streams while handling emoji precedence and maintaining alphabetical order for ties.
Fixes: #1202