Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: Open links in-app on Android #295

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

rajveermalviya
Copy link
Collaborator

url_launcher plugin now supports the desired behavior, which is using Android Custom Tabs, so we don't need the workaround of opening the links in external browser anymore, thus removed them.

Upstream PR:
flutter/packages#4739

Fixes #279

@rajveermalviya rajveermalviya marked this pull request as ready for review September 1, 2023 08:44
gnprice and others added 2 commits November 6, 2023 19:57
This gets us Android Custom Tabs support, via Rajesh's upstream PR:
  flutter/packages#4739
`url_launcher` plugin now supports the desired behavior, which is using
Android Custom Tabs, so we don't need the workaround of opening the
links in external browser anymore, thus removed them.

Fixes: zulip#279
@gnprice
Copy link
Member

gnprice commented Nov 7, 2023

Thanks @rajveermalviya! This looks great — merging, with small changes:

  • I pulled out the change to our dependencies as its own prep commit. If you look at our past dependency-updating commits, you'll see we keep them separate from code changes; try either the gitk graphical Git viewer, like gitk pubspec.*, or a command like git log --stat -p --full-diff pubspec.* plus my "secret" for using git log -p .
    • I also narrowed down that commit to make just the one change related to the rest of this PR.
  • I updated some tests that appeared when rebasing this onto main.

It'll be great to have this fix. Sorry I've been distracted and took so long to come back and integrate it.

@gnprice gnprice merged commit 806a81a into zulip:main Nov 7, 2023
1 check passed
@rajveermalviya rajveermalviya deleted the android-links branch November 8, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open links in-app by default on Android, once that has a good UX
2 participants