Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Add Unreads model, for tracking unread-message counts #304

Merged
merged 7 commits into from
Oct 23, 2023
Merged

model: Add Unreads model, for tracking unread-message counts #304

merged 7 commits into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. api [nfc]: Add warning about a list not being sorted 

    As Greg suggests:
  zulip#304 (comment)
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e52d3f6 View commit details
    Browse the repository at this point in the history

  2. algorithms [nfc]: Pull local helper isSortedWithoutDuplicates out to … 

    …here
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d40e5ff View commit details
    Browse the repository at this point in the history

  3. api: Assert that unread dm and stream snapshots have sorted message IDs 

    See discussion, which should produce a docs change soon:
  https://chat.zulip.org/#narrow/stream/412-api-documentation/topic/register.3A.20.60unread_message_ids.60.20sorted.3F/near/1647932
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    18806be View commit details
    Browse the repository at this point in the history

  4. api: Ensure DeleteMessageEvent.{streamId,topic} present when stream m… 

    …essage
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    667d191 View commit details
    Browse the repository at this point in the history

  5. narrow [nfc]: Move DmNarrow.withUser{,s} factories near plain constru… 

    …ctor

As Greg points out (before withUsers was added, but it should apply
to that too):
  zulip#304 (comment)

> [withUser] and `ofMessage` and the plain one are the really
> general-purpose constructors; as the number of special-purpose
> constructors grows, it starts getting pushed down where it's
> harder to spot.
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5c34d2c View commit details
    Browse the repository at this point in the history

  6. algorithms: Add setUnion, operating on sets implemented as sorted lists 

    Transcribed from the same-named function in zulip-mobile: see
src/immutableUtils.js.
    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1fde1da View commit details
    Browse the repository at this point in the history

  7. model: Add Unreads model, for tracking unread-message counts

    @chrisbobbe
    chrisbobbe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0266ff4 View commit details
    Browse the repository at this point in the history