-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Zulip internal links #305
Merged
Merged
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2f944a0 - Browse repository at this point
Copy the full SHA 2f944a0View commit details -
lint: Suppress constant_identifier_names in generated files
This was preventing us from making private `JsonEnum` classes as the generated `EnumMap` does not follow the rule of being a lowerCamelCase identifier. For example, `_Foo` generates `_$_FooEnumMap` and was triggering an analyzer complaint.
Configuration menu - View commit details
-
Copy full SHA for 1cfa5dc - Browse repository at this point
Copy the full SHA 1cfa5dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c65bab8 - Browse repository at this point
Copy the full SHA c65bab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 664f4a5 - Browse repository at this point
Copy the full SHA 664f4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cf1b36 - Browse repository at this point
Copy the full SHA 2cf1b36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5ec69 - Browse repository at this point
Copy the full SHA 9a5ec69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4beb7bb - Browse repository at this point
Copy the full SHA 4beb7bbView commit details
Commits on Oct 13, 2023
-
internal_link: Parse internal links into narrows
The core process on parsing internal links (here in `lib/model/internal_link.dart`) relied heavily on the existing code in the Zulip mobile app - from `src/utils/internalLinks.js`. In fact the `_parseStreamOperand` function here is a line for line port in order to capture the same semantics when processing streams. Where the implementation differs is this new process is less restrictive on the order of operator/operand pairs: supporting `#narrow/topic/_/stream_` where mobile only accepted `#narrow/stream/_/topic/_`. Also, the mobile implementation accepted as valid narrows DM operators with an email address as the operand (`#narrow/dm/a.40b.2Ecom.2Ec.2Ed.2Ecom`) but created an invalid narrow object (with NaNs for targets) whereas this implementation rejects them as invalid narrows. Likewise the test cases are also taken from the mobile code (`src/utils/__tests__/internalLinks-test.js`) and replicated here, save for the special narrow types (`#narrow/is/starred`) which are not yet implemented. Also, the "without realm info" cases were removed as they were made moot with every test case being passed through `tryResolveOnRealmUrl` (the mobile cases were also passed through `new Url()` with a base).
Configuration menu - View commit details
-
Copy full SHA for e3a2dcc - Browse repository at this point
Copy the full SHA e3a2dccView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.