deps: Update Flutter and packages #316
Conversation
|
CI failures. Very interesting! Glad to have #314 in, to help us detect what are probably real things to fix here. 🙂 output |
|
Cool! Locally, |
|
Also we should probably have |
Cool, I'll try that. The one thing I tried before that is: $ dart run build_runner build --delete-conflicting-outputsand that made these changes: diff --git lib/model/database.g.dart lib/model/database.g.dart
index a7964f85a..b7f008675 100644
--- lib/model/database.g.dart
+++ lib/model/database.g.dart
@@ -78,9 +78,10 @@ class $AccountsTable extends Accounts with TableInfo<$AccountsTable, Account> {
ackedPushToken
];
@override
- String get aliasedName => _alias ?? 'accounts';
+ String get aliasedName => _alias ?? actualTableName;
@override
- String get actualTableName => 'accounts';
+ String get actualTableName => $name;
+ static const String $name = 'accounts';
@override
VerificationContext validateIntegrity(Insertable<Account> instance,
{bool isInserting = false}) {I'll reset and try that command with |
|
Cool. Yeah, I expect that's the same thing that the |
|
Oh hmm, I think my run of |
|
Oh. Yeah, I ran into that too when testing One workaround is to change the input file, rerun, then change it back and rerun. A mitigating factor is that I think this sequence isn't likely outside of scenarios like testing the different workflows, as you're doing and I was doing. Still seems like not great behavior for |
|
Cool. Yeah, I recovered by running Pushed a revision, but I don't yet understand the changes to the generated files and I think I should find out and write about it in the commit message :) |
Hmm, yeah, I don't get it yet. At least the changes to the Dart files look NFC. With an online JSON diff checker I found that just one part of test/model/schemas/drift_schema_v2.json changed: the JSON object's |
|
Here's a command line for that diff BTW:
The change is a bit puzzling; I'd have expected it to be mentioned in the release notes: But presumably its omission there is just an oversight, and the change is because the new version of Drift changed the format of these schema files.
This one I think I do understand: it's because the code generator only generates the latest version of the schema. Which is because that's the only version it can generate, because that's the one it has the source code for, in This does suggest that strictly there's no need to update |
There are currently no upgrades that `--major-versions` would add beyond these. This includes the results of doing a build for iOS and for macOS; the iOS Podfile.lock takes an update. For the changes in lib/ and test/, see Greg's analysis here: zulip#316 (comment)
|
Thanks! Revision pushed, with the commit message pointing to your comment above: #316 (comment) |
And update Flutter's supporting libraries to match.
There are currently no upgrades that `--major-versions` would add beyond these. This includes the results of doing a build for iOS and for macOS; the iOS Podfile.lock takes an update. For the changes in lib/ and test/, see Greg's analysis here: zulip#316 (comment)
|
Thanks! Looks good; merging. |
No description provided.