Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Flutter, packages to latest #335

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

chrisbobbe
Copy link
Collaborator

Since this includes minor-version bumping of some Firebase related dependencies, I did a quick check on the office Android device that the functionality in #325 / #333 still works.

And update Flutter's supporting libraries to match.
Plus:

- `flutter build ios --config-only`
- `flutter build macos --config-only`
- `dart run build_runner build` (as prompted by a
  `tools/check build_runner` failure)
This is the result of `flutter pub upgrade --major-versions`, and
fixes for newly flagged lint errors in a few places:
  https://dart.dev/tools/linter-rules/use_super_parameters
  https://dart.dev/tools/linter-rules/dangling_library_doc_comments

(Plus `flutter build ios --config-only` and
`flutter build macos --config-only`, but it has no effect on our
`Podfile.lock`s, which isn't surprising for a dev dependency.)

Changelog:
  https://github.com/flutter/packages/blob/main/packages/flutter_lints/CHANGELOG.md#300
@gnprice
Copy link
Member

gnprice commented Oct 25, 2023

Thanks for taking care of these! LGTM — please go ahead and merge once CI passes.

@chrisbobbe chrisbobbe merged commit 0e79307 into zulip:main Oct 25, 2023
1 check passed
@chrisbobbe chrisbobbe deleted the pr-deps branch October 25, 2023 19:29
@chrisbobbe
Copy link
Collaborator Author

Thanks! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants