Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notifications! on Android, in foreground #344

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Show notifications! on Android, in foreground #344

merged 3 commits into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. deps: Add flutter_local_notifications and its platform interface 

    We'll use the latter for writing our binding class.
    @gnprice
    gnprice committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d17939e View commit details
    Browse the repository at this point in the history

  2. binding: Add flutter_local_notifications bindings

    @gnprice
    gnprice committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    24b3ad0 View commit details
    Browse the repository at this point in the history

  3. notif: Show notifications! on Android, in foreground 

    This implements most of the remaining work of zulip#320.

It doesn't yet deliver most of the user-facing value: for that, the
remaining piece will be to make notifications appear when the app is
in the background as well as when it's in the foreground.  I have a
draft for that and it works, but the tests require some more fiddling
which I may not get to today, so I wanted to get the bulk of this
posted for review.

Many other improvements still to be made are tracked as their own
issues: most notably iOS support zulip#321, and opening a conversation
by tapping the notification zulip#123.
    @gnprice
    gnprice committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b6badf5 View commit details
    Browse the repository at this point in the history