api: Mark messages as read (markAllAsRead, markStreamAsRead, markTopicAsRead) #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirpengi
changed the title
Merged
gnprice
reviewed
Nov 4, 2023
lib/api/route/messages.dart
Outdated
| /// https://zulip.com/api/mark-stream-as-read | ||
| /// | ||
| /// This binding is deprecated, in FL 155+ use | ||
| /// updateMessageFlagsForNarrow instead. |
There was a problem hiding this comment.
nit: linkify:
Suggested change
| /// updateMessageFlagsForNarrow instead. | |
| /// [updateMessageFlagsForNarrow] instead. |
test/api/route/messages_test.dart
Outdated
| }) async { | ||
| connection.prepare(json: {}); | ||
| await markStreamAsRead(connection, streamId: streamId); | ||
| check(connection.lastRequest).isNotNull().isA<http.Request>() |
There was a problem hiding this comment.
Suggested change
| check(connection.lastRequest).isNotNull().isA<http.Request>() | |
| check(connection.lastRequest).isA<http.Request>() |
As I mentioned in our call yesterday, the isNotNull is redundant with the subsequent isA. The type we're checking for with isA already excludes null.
(I think I originally introduced this redundant pattern to this file. But we should stop propagating it.)
There was a problem hiding this comment.
→ #369 for the existing cases of that pattern.
sirpengi
force-pushed
the
pr-api-mark-foo-as-read
branch
from
b270ba6
to
6d9f22d
Compare
|
@gnprice this is ready as well! |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr was split off from #361.
Also fixes part of #130