Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose_box: Replace compose box with a banner when cannot post in a channel #886

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

compose_box: Replace compose box with a banner when cannot post in a channel #886

wants to merge 8 commits into from
+338 −95

Commits on Oct 7, 2024

  1. api: Add realmWaitingPeriodThreshold to InitialSnapshot 

    This is necessary in the next commit(s) where wee need to determine if a
a user has become a full member.

For how to determine if a user is a full member, see:
  https://zulip.com/api/roles-and-permissions#determining-if-a-user-is-a-full-member
    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ffb3238 View commit details
    Browse the repository at this point in the history

  2. store: Add realmWaitingPeriodThreshold to PerAccountStore

    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9616005 View commit details
    Browse the repository at this point in the history

  3. model: Add hasPassedWaitingPeriod helper method to User

    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6cf3dd9 View commit details
    Browse the repository at this point in the history

  4. model: Add hasPostingPermission helper method to ZulipStream 

    Also add `UserRole.isAtLeast` method.
    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d1c16a9 View commit details
    Browse the repository at this point in the history

  5. test [nfc]: Have eg.user accept dateJoined and role

    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5aaad2d View commit details
    Browse the repository at this point in the history

  6. compose_box test [nfc]: Have prepareComposeBox accept additional pa… 

    …rams

The additional params are: selfUser, streams, and realmWaitingPeriodThreshold.
    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    dc9a330 View commit details
    Browse the repository at this point in the history

  7. test [nfc]: Add streams and eg.selfUser to store in several tests 

    Adding these is necessary for the next commit(s), otherwise these
tests will fail.
    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    58276c3 View commit details
    Browse the repository at this point in the history

  8. compose_box: Replace compose box with a banner when cannot post in a … 

    …channel

Fixes: zulip#674
    @sm-sayedi
    sm-sayedi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    be0d74d View commit details
    Browse the repository at this point in the history