icons: Updated bot icon with single antenna version.

[fombalang]

This PR updates the previous bot icon, replacing it with a new single antenna bot icon.

No tests have been written or updated for this PR as the changes made were minimal and did not involve changing any dart code, just updating the SVG asset file and rebuilding the icon font.

Fixes: #978

Thank you.

[chrisbobbe]

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

[PIG208]

Looks like the update to this file is unintended.

[fombalang]

Yes, it was unintended. It was changed when I ran a flutter pub get

[fombalang]

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Yes, the icon was gotten from the zulip repository from this PR about updating the icon. zulip/zulip#31673
I downloaded the SVG file from that repository and used it. Specifically from https://github.com/zulip/zulip/blob/main/web/shared/icons/bot.svg

[fombalang]

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Yes, the icon was gotten from the zulip repository from this PR about updating the icon. zulip/zulip#31673 I downloaded the SVG file from that repository and used it. Specifically from https://github.com/zulip/zulip/blob/main/web/shared/icons/bot.svg

Should I send an updated commit with a description of where I got the icon from or adding a comment here would be fine? @chrisbobbe

[chrisbobbe]

Yes, please update the commit. As I said above:

[…] The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

[fombalang]

Yes, please update the commit. As I said above:

[…] The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Okay, understood, thank you.

[fombalang]

I have updated the commit @chrisbobbe

[chrisbobbe]

Thanks! Comment below, and it looks like you still need to remove the accidental pubspec.lock changes.

[chrisbobbe]

icons: Updated bot icon with single antenna version.

Icon gotten from the Github Zulip repository at https://github.com/zulip/zulip/blob/main/web/shared/icons/bot.svg

Notes on the commit message:

• Thanks for including a URL for the SVG. It may become out of date, though, as the main branch advances in the zulip/zulip repository. So let's point to a specific commit. The commit that added the file would be a good one:

  - https://github.com/zulip/zulip/blob/main/web/shared/icons/bot.svg
  + https://github.com/zulip/zulip/blob/030f93595/web/shared/icons/bot.svg

• In zulip-flutter the summary line is in the imperative and without a final period, so: "icons: Update bot icon with single antenna version"

• Wrap the text of the commit-message body to 68 columns

• Add a Fixes: #978 line (in the commit and also the PR description)

For examples of merged commit messages, see the project's history.

[fombalang]

Okay, noted, thank you

[chrisbobbe]

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

[fombalang]

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

Yeah, I was actually confused about what to do with URLs, let me update that then.

[fombalang]

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

Yeah, I was actually confused about what to do with URLs, let me update that then.

Updated

[chrisbobbe]

Ah, and one thing I forgot in my previous reviews: since this makes a visible change, please post before/after screenshots. The code and commit message look good to me though, and I'll move this along to Greg for his review (but please do post those screenshots).

[chrisbobbe]

Oh, I see you did post screenshots, just on the issue thread instead of here: #978 (comment)

In future, please post the screenshots on the PR thread. But I do think those screenshots look good.

[gnprice]

Thanks @fombalang for taking care of this, and @chrisbobbe @PIG208 for the previous reviews!

This looks good; merging. I fixed one nit in the commit message:

-    icons: Update bot icon with single antenna version
+    icons: Update bot icon with single-antenna version