lightbox: Use a friendlier format for the date #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Oct 7, 2024
Comment on lines
+150
to
+164
| if (difference.inSeconds < 60) { | ||
| return "A few seconds ago"; | ||
| } else if (difference.inMinutes < 60) { | ||
| return "${difference.inMinutes} ${difference.inMinutes == 1 ? 'minute' : 'minutes'} ago"; | ||
| } else if (difference.inHours < 24) { | ||
| final time = DateFormat.jm(locale).format(messageDate); | ||
| return "Today at $time"; | ||
| } else if (difference.inHours < 48) { | ||
| final time = DateFormat.jm(locale).format(messageDate); | ||
| return "Yesterday at $time"; | ||
| } else { | ||
| final date = DateFormat('MMM d, yyyy', locale).format(messageDate); | ||
| final time = DateFormat('hh:mm a', locale).format(messageDate); | ||
| return "$date at $time"; | ||
| } |
There was a problem hiding this comment.
These are untranslated English strings. Instead, we should show strings in the user's chosen language.
There was a problem hiding this comment.
Thank you for the feedback, @chrisbobbe.
Please can you provide a suggestion on how i should achieve that?
There was a problem hiding this comment.
I'm not able to prioritize that right now; this is a post-launch issue. Maybe there's a library out there that can handle this for us?
There was a problem hiding this comment.
Okay thank you, I will look that up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue of displaying a user friendly date format in the lightbox appbar rather than showing the normal timestamp.
fixes #45