-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom selector for V3.0 #216
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported code from old foundation-sites-6:joyride branch. Aligned code with latest F6 code. Some ES6 stuff. Added a basic demo (containing some open points/future features).
First draft for javascript tests. Commenting for configuration parameters.
Reorganized files accordint to guideline: https://github.com/zurb/foundation-standards/blob/master/folders.md. Adjusted gulp tasks accordingly
Demo for standalone files. Enhanced test cases for JS. Added MediaQuery to SCSS dependency files so tooltips get opened and not fail because MQs are missing.
Added showOn-option to deal with missing MediaQueries in standalone verion.
Added demo page for UMD using requireJS.
Updated demo pages. Added whatinput rule in SASS.
Added more commands to package.json. Remove sinon. Adjusted path for JS test set.
Added browser-sync. Implemented watching of files + browser reloading. Moved demo files to tests/visual. Visual tests now run default gulp task, which will build, watch and serve files.
Normal gulp tasks will now output to _build/assets/. Minified JS and CSS are only generated when using the new dist task. Changed the links in the docs (external dependencies are now found in lib/, plugin files in assets/).
Moved to issue #217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I love this tool :)
Description of the feature
I've made a tiny mod easy to integrate that will allow you to select targets using a custom css selector directly with a
data-customselector
html attributeTechnical purpose
Inside the method definition of
set_target
on the jquery.joyride.js file i want to suggest this tiny addon:From this:
To this:
What It's changing? (3 lines)
Example of usage
Inside the
<ol>
s each<li>
will now support adata-customselector
attribute.This has been tested by me. Fell free to contribute. ✔️
⚠️ As for classes even in this custom css selector will be always taken the
:first()
target found.