Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax content loading (jQuery version) #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ajax content loading (jQuery version) #32

wants to merge 1 commit into from

Conversation

GooseRockDesign
Copy link

I Added ajax content loading functionality to the jquery reveal plugin. I also cleaned up a lot of the code and the indentation.

List of squashed commits:

  • Updated local jquery
  • Added ajax content loading for jquery
  • Abstraction!
  • Lightboxen ought to be above everything
  • Fixed a flickering bug on fade out
  • Added "complete" events
  • Added option to toggle close on escape key event
  • Name change: reveal-path -> reveal-url
  • Added ajax loader gif
  • Option for escape key
  • Improved indentation; fully fleshed out ajax loading with a loader and a custom "complete" event
  • Added a slight visual effect to the ajax loading process

… I also cleaned up a lot of the code and the indentation.

Updated local jquery

Added ajax content loading for jquery

Abstraction!

Lightboxen ought to be above *everything*

Fixed a flickering bug on fade out

Added "complete" events

Added option to toggle close on escape key event

Name change: reveal-path -> reveal-url

Added ajax loader gif

Option for escape key

Improved indentation; fully fleshed out ajax loading with a loader and a custom "complete" event

Added a slight visual effect to the ajax loading process
@shadowhand
Copy link

Personally, I would prefer that Reveal assume that attaching to an a[href] will load the referenced link, assuming it is not an #id anchor. Fancybox is the best example (imo) for how defaults should be determined based on the element that activates the modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants