feat(config): add missing and new parameters for ZEN15 #7495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Inspired by #7494, I copied the label conditional to my branch, but I wonder if it should check hardwareVersion instead... |
I don't think hardwareVersion check is necessary. Pretty sure you cannot successfully load the version 2.0+ firmware onto the older variant without bricking it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-ordered parameters to match documentation
Added parameter 35 for firmware v2.0 (based on mis-documented parameter 25 in change log)
Updated parameter 20 for firmware v2.10
Added parameters 36, 175, and 176 for firmware v2.10
Added missing parameters 31 and 32
Added unit (W) to parameter 151
Re-labeled parameters 151 and 174 to more closely match documentation