Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gzip/base64 in dictionaries as it increases the bundle size #294

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

MrWook
Copy link
Collaborator

@MrWook MrWook commented Jan 2, 2025

@mimi89999 unfortunately i needed to remove the pre gzip/base64 encoding from the compress library as the browser build were getting bigger instead of smaller.

Here are my test result with a basic nginx gzip configuration and vite chunks:

3.x.x
common: 232kb
en: 565kb

4.x.x
common: 247kb => +15kb
en: 591kb => +26kb

4.x.x without pre gzip/base64
common: 225kb => -7kb
en: 493kb => -72kb

But i will keep some suggestion by lifthrasiir from #254

@MrWook MrWook added the enhancement New feature or request label Jan 2, 2025
@MrWook MrWook merged commit 592d1c7 into master Jan 2, 2025
6 checks passed
@MrWook MrWook deleted the fix/remove-gzip-and-base64-for-dictionaries branch January 2, 2025 15:54
@mimi89999
Copy link
Contributor

So Nginx is doing a better job at compressing the dict files than fflate? I didn't quite expect that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants