Add impersonation support to send_packet service #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for impersonation using the send_packet service.
I use it to send fan_demand packets from my faked CO2 sensor, because ramses_rf doesn't support that yet.
I couldn't practically solve this use-case with a remote, because you have to predefine the commands in a remote, which is not very suitable for fan_demand packets, since you specify the demand percentage - you would need to create 100 commands for it.
I submitted this PR before, I hope you would consider merging it. If not, I will have to switch to using my own fork instead.