Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with llvm-rc when ZYCORE_BUILD_SHARED_LIB is enabled #70

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

netadr
Copy link
Contributor

@netadr netadr commented Apr 6, 2024

If llvm-rc is used as the resource compiler, the following error occurs if ZYCORE_BUILD_SHARED_LIB is enabled:

llvm-rc: Error in VERSIONINFO statement (ID 1):
Non-ASCII 8-bit codepoint (�) can't be interpreted in the current codepage

This is a common issue encountered with llvm-rc, see curl/curl#7765.
Following the workaround from libcurl, this pull request changes the copyright symbol © to (C).

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the workaround!

@flobernd flobernd merged commit 13114fa into zyantific:master Apr 7, 2024
24 checks passed
mochaaP added a commit to mcha-forks/zycore-c that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants