Use gimp rendering in docker and fix gimp font #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the wrong history here, it was a commit done after my own load save thing. The only change needed is the one in
manga_translator/mode/local.pyI noticed that the ctx.gimp_font was None even if I use it in the config file. The proper way would be to use the config object directly, but it's too much difficult for me so instead I just patch the ctx directly.
I cannot do it when we create it first because it is overwritten by the translation method.
I just tested it in local mode, so maybe there are some issues with the other methods.
Regards