Exposing replacement functions for deprecated IOUtil functions #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neko-Box-Coder
force-pushed
the
ReplacingDeprecatedIOUtil
branch
2 times, most recently
from
3327d47
to
8a5c89e
Compare
niten94
reviewed
Aug 7, 2024
There was a problem hiding this comment.
It is written in the commit message that the functions are replaced but it may be thought that the deprecated functions are removed. I do not think they should be removed yet, but I think it will be fine only changing the commit message to something like "Expose replacement of deprecated ioutil functions to plugins".
Neko-Box-Coder
force-pushed
the
ReplacingDeprecatedIOUtil
branch
from
8a5c89e
to
bb742ff
Compare
|
Yeah thanks, I forgot to change the commit message when amending the commit. |
niten94
approved these changes
Aug 7, 2024
Neko-Box-Coder
changed the title
JoeKar
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ioutil functions we have at the moment are deprecated by go.
These are
ReadAll()ReadDir()ReadFile()WriteFile()We should instead use the functions mentioned on the doc