-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for django official versions #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irtazaakram and thanks for your contribution, really appreciated!
AFAIK, Django 3.2 (LTS) still supports Python 3.6 and 3.7. I searched the release notes for the 3.2 series but I haven't found any deprecation of those Python versions. Thus, can you bring back the support for those in your PR, please?
I noticed Django 4.1 (since 4.1.3) and 4.2 are also compatible with Python 3.11. Would you be keen on adding support for that Python version too?
Once done, we should be good to merge and cut a release because every other changes lgtm 👍🏻
PS: I'm just about to leave for some holidays, expect some delay from my side :(
- added back python 3.6 & 3.7 support
Hi @zyegfryed, Thank you for the review. I've added back python 3.6 & 3.7 and also added 3.11 to tests. Enjoy your holidays :-) Thanks, |
Hey @zyegfryed, Apologies. I used incorrect python name in Again sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌🏻
@irtazaakram just merged your PR in the main branch, thanks for your great job. |
Thank you @zyegfryed |
Hi @irtazaakram, |
Thank you @zyegfryed 🙌 |
Hi
I've made this PR that
can we also have a new release after this PR is merged?
Thanks