Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for django official versions #57

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

irtazaakram
Copy link
Contributor

@irtazaakram irtazaakram commented Jul 25, 2023

Hi

I've made this PR that

  • add support for Django 4.1 & 4.2
  • drop support for Django 4.0
  • add support for Python 3.11
  • update GitHub actions

can we also have a new release after this PR is merged?

Thanks

Copy link
Owner

@zyegfryed zyegfryed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irtazaakram and thanks for your contribution, really appreciated!

AFAIK, Django 3.2 (LTS) still supports Python 3.6 and 3.7. I searched the release notes for the 3.2 series but I haven't found any deprecation of those Python versions. Thus, can you bring back the support for those in your PR, please?

I noticed Django 4.1 (since 4.1.3) and 4.2 are also compatible with Python 3.11. Would you be keen on adding support for that Python version too?

Once done, we should be good to merge and cut a release because every other changes lgtm 👍🏻

PS: I'm just about to leave for some holidays, expect some delay from my side :(

docs/changelog.rst Outdated Show resolved Hide resolved
- added back python 3.6 & 3.7 support
@irtazaakram
Copy link
Contributor Author

Hi @zyegfryed,

Thank you for the review.

I've added back python 3.6 & 3.7 and also added 3.11 to tests.

Enjoy your holidays :-)

Thanks,

@irtazaakram
Copy link
Contributor Author

Hey @zyegfryed,

Apologies. I used incorrect python name in build.yml. I've fixed it and also updated python versions.

Again sorry.

@zyegfryed zyegfryed self-requested a review July 26, 2023 18:54
Copy link
Owner

@zyegfryed zyegfryed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏻

@zyegfryed zyegfryed merged commit 69ece12 into zyegfryed:main Jul 26, 2023
6 checks passed
@zyegfryed
Copy link
Owner

@irtazaakram just merged your PR in the main branch, thanks for your great job.
Will try to cut a release within few days

@irtazaakram irtazaakram deleted the update branch July 27, 2023 05:19
@irtazaakram
Copy link
Contributor Author

Thank you @zyegfryed

@zyegfryed
Copy link
Owner

Hi @irtazaakram,
I just cut the release v2.4.0 with the up-to-date docs.
Thanks agin for your great work 👍🏻

@irtazaakram
Copy link
Contributor Author

Thank you @zyegfryed 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants