Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it manually with a raw spider defined on a https://github.com/zytedata/zyte-spider-templates-project project with the 2 setting changes needed:
Should I also figure out a way to test it? It feels like writing the test will take longer than implementing the feature took, so I am not sure whether or not it is worth it. And if we do, should we aim to test both possible close paths (
_maybe_close
calls)? Would tests that create the 2 middlewares and “play” with them work, as opposed to running an actual spider on a mock local website?