feat: block interval and parallel block proving #90

atanmarko · 2024-06-03T15:50:56Z

Resolves #87
Resolves #88
Resolves #89

Nashtare

First pass looking good, though I'll probably do a second round later. Also leaving the async stuff and related TODO questions to people more familiar (@0xaatif @cpubot)

common/src/block_interval.rs

leader/src/jerigon.rs

leader/src/main.rs

prover/src/lib.rs

tools/prove_blocks.sh

common/src/block_interval.rs

prover/src/lib.rs

leader/src/jerigon.rs

common/src/block_interval.rs

common/src/parsing.rs

common/src/block_interval.rs

tools/witness.json

0xaatif

nits

Cargo.toml

common/src/block_interval.rs

common/src/parsing.rs

* feat: implement concurrent block proving #88 #89 * Update prover/src/lib.rs Co-authored-by: 0xaatif <[email protected]> * fix suggestion * Fix duplicated import when #[cfg(feature = "test_only")] --------- Co-authored-by: 0xaatif <[email protected]> Co-authored-by: Marko Atanasievski <[email protected]>

common/src/block_interval.rs

0xaatif · 2024-06-07T12:52:59Z

common/src/block_interval.rs

+            } => Ok(try_stream! {
+                let mut current = start_block;
+                 loop {
+                    let last_block_number = provider.get_block_number().await.map_err(|e: alloy::transports::RpcError<_>| {


I'm surprised you can't elide the type. Also .context could work here

Compiler insisted for some reason

0xaatif · 2024-06-07T12:53:34Z

common/src/block_interval.rs

+                        current += 1;
+                        yield current;
+                    } else {
+                       info!("Waiting for the new blocks to be mined, requested block number: {current}, \


Nit: I prefer structured logging for stats

0xaatif · 2024-06-07T12:54:11Z

common/src/block_interval.rs

+                    }
+                }
+            }),
+            _ => Err(anyhow!(


nit: could be bail!

Nashtare

Out of curiosity, have we tested the new behavior against actual multiple blocks? To make sure workers are picking up jobs properly, there's no weird synchronicity issues, we don't get overlasting delays on the first blocks upon increased work pressure, etc...

atanmarko · 2024-06-07T13:03:41Z

Out of curiosity, have we tested the new behavior against actual multiple blocks? To make sure workers are picking up jobs properly, there's no weird synchronicity issues, we don't get overlasting delays on the first blocks upon increased work pressure, etc...

@Nashtare Yes, I did tests with 5 blocks range, both test_only and real mode. Seems to work without issues

muursh · 2024-06-07T15:01:17Z

Out of curiosity, have we tested the new behavior against actual multiple blocks? To make sure workers are picking up jobs properly, there's no weird synchronicity issues, we don't get overlasting delays on the first blocks upon increased work pressure, etc...

@Nashtare Yes, I did tests with 5 blocks range, both test_only and real mode. Seems to work without issues

Once this is in develop we can ask @praetoriansentry to bully it for us.

praetoriansentry · 2024-06-07T16:04:58Z

Once this is in develop we can ask @praetoriansentry to bully it for us.

atanmarko self-assigned this Jun 3, 2024

atanmarko force-pushed the feat/block-interval branch 5 times, most recently from 9197924 to d260a41 Compare June 3, 2024 16:51

atanmarko and others added 3 commits June 4, 2024 18:21

feat: add block interval

728127e

fix: follow from loop

dcdd0f4

feat: add block hash parsing for interval

9ee3a2a

atanmarko force-pushed the feat/block-interval branch 2 times, most recently from 6f5d0e7 to bc2ff6e Compare June 5, 2024 12:27

fix: proving logic

c69de80

atanmarko force-pushed the feat/block-interval branch from bc2ff6e to c69de80 Compare June 5, 2024 12:57

atanmarko changed the title ~~WIP: block interval~~ feat: block interval Jun 5, 2024

atanmarko marked this pull request as ready for review June 5, 2024 13:01

atanmarko requested review from cpubot, muursh and Nashtare as code owners June 5, 2024 13:01

atanmarko requested a review from 0xaatif June 5, 2024 14:00

Nashtare reviewed Jun 5, 2024

View reviewed changes

cpubot suggested changes Jun 5, 2024

View reviewed changes

common/src/block_interval.rs Outdated Show resolved Hide resolved

common/src/block_interval.rs Outdated Show resolved Hide resolved

prover/src/lib.rs Outdated Show resolved Hide resolved

prover/src/lib.rs Outdated Show resolved Hide resolved

fix: typos

fc17dbb

atanmarko force-pushed the feat/block-interval branch from 5733a4a to fc17dbb Compare June 5, 2024 14:33

cpubot suggested changes Jun 5, 2024

View reviewed changes

leader/src/jerigon.rs Outdated Show resolved Hide resolved

0xaatif suggested changes Jun 5, 2024

View reviewed changes

fix: review

2a81ffe

cpubot mentioned this pull request Jun 5, 2024

feat: implement concurrent block proving #88 #89 #96

Merged

fix: doc tests

c090919

atanmarko force-pushed the feat/block-interval branch from 319c8a9 to c090919 Compare June 5, 2024 16:25

0xaatif mentioned this pull request Jun 5, 2024

refactor/remove common::parsing 0xPolygonZero/zk_evm#284

Closed

atanmarko added 4 commits June 6, 2024 11:27

feat: add block time cli argument

9518616

fix: interval display

4c73cf3

feat: add from string for block interval

db4977f

fix: remove block interval single variant

9114a4c

atanmarko requested review from cpubot and Nashtare June 6, 2024 11:06

0xaatif reviewed Jun 6, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

common/src/block_interval.rs Outdated Show resolved Hide resolved

common/src/parsing.rs Outdated Show resolved Hide resolved

cpubot and others added 3 commits June 6, 2024 16:11

fix: block interval fmt

18b4350

fix: make parsing functions private

4456338

muursh reviewed Jun 6, 2024

View reviewed changes

common/src/block_interval.rs Outdated Show resolved Hide resolved

atanmarko changed the title ~~feat: block interval~~ feat: block interval and parallel block proving Jun 7, 2024

atanmarko added 2 commits June 7, 2024 10:47

fix: use futures iterator instead of tokio-stream

4783f1a

fix: use anyhow error instead of block interval error

4d469c0

atanmarko requested review from muursh and 0xaatif June 7, 2024 09:43

0xaatif approved these changes Jun 7, 2024

View reviewed changes

Nashtare reviewed Jun 7, 2024

View reviewed changes

Merge remote-tracking branch 'origin/develop' into HEAD

56856db

cpubot approved these changes Jun 10, 2024

View reviewed changes

atanmarko merged commit 69b170c into develop Jun 10, 2024
4 checks passed

atanmarko deleted the feat/block-interval branch June 10, 2024 15:28

This was referenced Jun 11, 2024

Add support for block intervals #86

Closed

feat: improve block hashes fetching #62

Closed

Nashtare mentioned this pull request Jun 18, 2024

Add support for generating multiple block proofs at once 0xPolygonZero/zk_evm#296

Closed

temaniarpit27 mentioned this pull request Aug 14, 2024

Verify the checkpoint proof input 0xPolygonZero/zk_evm#286

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: block interval and parallel block proving #90

feat: block interval and parallel block proving #90

atanmarko commented Jun 3, 2024 •

edited

Loading

Nashtare left a comment

0xaatif left a comment

0xaatif Jun 7, 2024

atanmarko Jun 7, 2024

0xaatif Jun 7, 2024

0xaatif Jun 7, 2024

Nashtare left a comment

atanmarko commented Jun 7, 2024

muursh commented Jun 7, 2024

praetoriansentry commented Jun 7, 2024

feat: block interval and parallel block proving #90

feat: block interval and parallel block proving #90

Conversation

atanmarko commented Jun 3, 2024 • edited Loading

Nashtare left a comment

Choose a reason for hiding this comment

0xaatif left a comment

Choose a reason for hiding this comment

0xaatif Jun 7, 2024

Choose a reason for hiding this comment

atanmarko Jun 7, 2024

Choose a reason for hiding this comment

0xaatif Jun 7, 2024

Choose a reason for hiding this comment

0xaatif Jun 7, 2024

Choose a reason for hiding this comment

Nashtare left a comment

Choose a reason for hiding this comment

atanmarko commented Jun 7, 2024

muursh commented Jun 7, 2024

praetoriansentry commented Jun 7, 2024

atanmarko commented Jun 3, 2024 •

edited

Loading