Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand trace decoder tests #394

Merged
merged 12 commits into from
Jul 17, 2024
Merged

feat: expand trace decoder tests #394

merged 12 commits into from
Jul 17, 2024

Conversation

atanmarko
Copy link
Member

No description provided.

@atanmarko atanmarko self-assigned this Jul 15, 2024
@github-actions github-actions bot added the crate: trace_decoder Anything related to the trace_decoder crate. label Jul 15, 2024
@atanmarko atanmarko force-pushed the feat/expand-trace-decoder-tests branch from 3dd81f1 to 1fb8a7e Compare July 15, 2024 16:33
@0xaatif 0xaatif self-requested a review July 15, 2024 19:29
@atanmarko atanmarko force-pushed the feat/expand-trace-decoder-tests branch from 1fb8a7e to e01ad9e Compare July 16, 2024 12:24
@github-actions github-actions bot added crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. labels Jul 16, 2024
@atanmarko atanmarko changed the base branch from feat/cancun to develop July 16, 2024 12:25
@atanmarko atanmarko removed crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. labels Jul 16, 2024
@atanmarko
Copy link
Member Author

I need next to run locally cdk erigon to generate the input test data, as Cardona endpoint https://rpc.cardona.zkevm-rpc.com/ does not have enabled debug API.

@atanmarko atanmarko marked this pull request as ready for review July 16, 2024 15:29
@Nashtare Nashtare added this to the Testing and Validation milestone Jul 16, 2024
@atanmarko atanmarko force-pushed the feat/expand-trace-decoder-tests branch from a5971d0 to 8f13657 Compare July 16, 2024 15:48
@atanmarko atanmarko force-pushed the feat/expand-trace-decoder-tests branch from 0ae3108 to bdc1659 Compare July 16, 2024 15:54
Nashtare
Nashtare approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marko! Looks good to me!

.github/workflows/ci.yml Show resolved Hide resolved
trace_decoder/tests/trace_decoder_tests.rs Outdated Show resolved Hide resolved
trace_decoder/tests/trace_decoder_tests.rs Show resolved Hide resolved
trace_decoder/tests/trace_decoder_tests.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Jul 16, 2024
@atanmarko atanmarko force-pushed the feat/expand-trace-decoder-tests branch from 6d3fc32 to 084b089 Compare July 16, 2024 17:46
muursh
muursh reviewed Jul 17, 2024
View reviewed changes
trace_decoder/src/type1.rs Outdated Show resolved Hide resolved
muursh
muursh approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

0xaatif
0xaatif approved these changes Jul 17, 2024
View reviewed changes
trace_decoder/tests/trace_decoder_tests.rs Outdated Show resolved Hide resolved
trace_decoder/tests/trace_decoder_tests.rs Outdated Show resolved Hide resolved
zero_bin/README.md Show resolved Hide resolved
@atanmarko atanmarko merged commit a5b92b2 into develop Jul 17, 2024
14 checks passed
@atanmarko atanmarko deleted the feat/expand-trace-decoder-tests branch July 17, 2024 12:24
This was referenced Jul 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@0xaatif 0xaatif 0xaatif approved these changes

@muursh muursh muursh approved these changes

Assignees

@atanmarko atanmarko

Labels
crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging this pull request may close these issues.
4 participants
@atanmarko @muursh @Nashtare @0xaatif