-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #4911 - Milestone 3: Step 3 - Planes height calibration #5069
Conversation
frontend/src/v5/ui/routes/dashboard/projects/calibration/calibration.constants.ts
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/routes/viewer/toolbar/selectionToolbar/selectionToolbar.component.tsx
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/routes/viewer/toolbar/selectionToolbar/selectionToolbar.styles.ts
Outdated
Show resolved
Hide resolved
export const VerticalSpatialBoundariesHandler = () => { | ||
const { verticalPlanes, setVerticalPlanes, vector3D, vector2D, isCalibratingPlanes, setIsCalibratingPlanes, drawingId, | ||
setSelectedPlane, selectedPlane, isAlignPlaneActive } = useContext(CalibrationContext); | ||
const planesRef = useRef(verticalPlanes); // ref needed to get plane values in useEffect without causing excessive retriggers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you actually need this ref? The places where it's used are the following lines:
- 106: useEffect dependencies, but useEffect does not detect changes in a ref;
- 90: you can probably just use verticalPlanes there instead (also, why do you clone the array?)
- 56: if what said above holds true, this bit becomes useless
...v5/ui/routes/viewer/toolbar/selectionToolbar/sections/planesCalibrationSection.component.tsx
Outdated
Show resolved
Hide resolved
...projects/calibration/calibrationStep/calibration2DHandler/calibration2DHandler.component.tsx
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/components/viewer/drawingViewer/viewerLayer2D/viewerLayer2D.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zane was questioning some of the UX on the demo branch so I had a look here to see if they've been addressed (Most of them are, so thank you 😆 ) but a few more things:
-
The drawings are appearing to be completely transparent on the background, making them very hard to view, can we make sure we impose a faint white background on it or something like that? very difficult to see at this point
-
can we only impose the drawing on the plane that is currently selected? have the unselected plane to just display with a mildly transparent white background. The lines overlap with each other and it's very difficult to see
-
I think we need the clip tool to be available here. If I'm trying to align a level 1 floor plan and I can't get into level one of the floor it's very bad UX. as soon as the bottom plane is established we can reset and disable the clip tool, but before that it will be useful
-
It's weird that you auto turn on the height calibration tool here, when we don't do that with horiztonal alignment. We should make it consistent.
Rest of the problems will be addressed in #5125 |
This fixes #4911
Description
Test cases
Use the Revit House model (found here), and use the drawings that are title 'rac level1', 'rac level2', and 'rac site'.
#### NOTE: There are two bugs that I need @sebjf to investigate related to re-entering calibration.When the vertical planes are set and the user cancels calibration and then re-enters the clipping from the previous vertical plane alignment reappears.Continuing from the previous point, if the user continues calibration again and sets some vertical planes the drawing image appears blank. The height, width, and alignment of the blank rectangle appears correct