-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #4911 - Milestone 3: Step 3 - Planes height calibration #5069
Changes from 66 commits
0439acf
22b4eb4
cebb3e4
1fb7909
3e12dbb
e16908a
8affbdb
394d848
3381f6f
76ded1e
13f07e5
5289a04
fe565b9
6b59d0f
ab5ab0b
f20cfe8
0f5b8dc
40404aa
7b2b99d
f99a9d9
642f3a9
3bfde52
fad752c
8a5788d
f36cbaf
606ff7d
486bce1
ac91ac6
e2bfe66
451dde3
af54b24
5dc92ab
798f633
a68aae3
cd2aec1
ed08791
014d0ba
76bf533
3f7c427
b1ec842
a294ce6
f787363
a2b3d99
964cd72
df7737c
8338092
732e5db
41d9e32
44b01df
4209c1f
2c957ab
97fb35a
38df92b
52ca2b6
4e79394
f8a6e68
e976f58
625f500
53a5d07
0051b7e
0d55cb8
a622a9c
5e7f44d
afeeaff
eec2ba0
b5c80d5
dfb0dc5
0492fa3
4ec84c4
c4e73b2
77a18b7
26c9a5d
6bff978
16ffdb5
d850dac
08b338f
709ca2c
8622250
36a1453
2e265cc
c1e68a0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/** | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sanmont3drepo what do you think? I feel like they should be initially enabled as that is the primary point of the step |
||
* Copyright (C) 2024 3D Repo Ltd | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Completing the calibration process (up to bottom and top plane) and trying to re-calibrate the drawing crashes the app There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have been unable to reproduce |
||
* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is how it should be as the user is like going to be using the cross section of walls whilst looking from above to calibrate it. It makes more sense now that I have added some transparency to the planes |
||
* This program is free software: you can redistribute it and/or modify | ||
The-Daniel marked this conversation as resolved.
Show resolved
Hide resolved
The-Daniel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* it under the terms of the GNU Affero General Public License as | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cancelling a calibration with planes sectioning the model and then starting a new calibration picks up the previous clipping view Registrazione.2024-07-17.105722.mp4 |
||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
type IProps = { | ||
className?: any; | ||
}; | ||
|
||
export default ({ className }: IProps) => ( | ||
<svg width="21" height="22" viewBox="0 0 21 22" fill="none" xmlns="http://www.w3.org/2000/svg" className={className}> | ||
<path d="M21 1.23828C21 1.64602 20.6695 1.97656 20.2617 1.97656L12.2739 1.97656C11.8662 1.97656 11.5356 1.64602 11.5356 1.23828C11.5356 0.83054 11.8662 0.5 12.2739 0.5L20.2617 0.5C20.6695 0.5 21 0.83054 21 1.23828Z" fill="currentColor"/> | ||
<path fillRule="evenodd" clipRule="evenodd" d="M0.750587 0.5C0.336049 0.5 1.1266e-06 0.83605 1.08484e-06 1.25059L0 20.7494C-2.30677e-08 21.164 0.336128 21.5 0.750586 21.5H6.11953C6.53407 21.5 6.87012 21.1639 6.87012 20.7494L6.87012 1.25059C6.87012 0.836061 6.53408 0.500001 6.11953 0.500001L0.750587 0.5ZM1.47656 20.0234L1.47656 1.97656L5.39356 1.97656V5.38086H3.594C3.18625 5.38086 2.85571 5.7114 2.85571 6.11914C2.85571 6.52688 3.18625 6.85742 3.594 6.85742H5.39356V10.2617H3.59399C3.18625 10.2617 2.85571 10.5923 2.85571 11C2.85571 11.4077 3.18625 11.7383 3.59399 11.7383H5.39356V15.1426H3.59399C3.18625 15.1426 2.85571 15.4731 2.85571 15.8809C2.85571 16.2886 3.18625 16.6191 3.59399 16.6191H5.39356L5.39355 20.0234H1.47656Z" fill="currentColor"/> | ||
<path d="M17.4305 5.13674C17.7189 5.42506 18.1863 5.42506 18.4746 5.13674C18.7629 4.84842 18.7629 4.38097 18.4746 4.09265L16.7859 2.40389C16.6474 2.26543 16.4596 2.18765 16.2638 2.18765C16.068 2.18765 15.8802 2.26543 15.7418 2.40389L14.0553 4.09038C13.767 4.37869 13.767 4.84615 14.0553 5.13446C14.3436 5.42278 14.8111 5.42278 15.0994 5.13446L15.5136 4.7202L15.5221 17.2906L15.0949 16.8633C14.8066 16.575 14.3391 16.575 14.0508 16.8633C13.7625 17.1517 13.7625 17.6191 14.0508 17.9074L15.7396 19.5962C15.878 19.7347 16.0658 19.8124 16.2616 19.8124C16.4574 19.8124 16.6452 19.7347 16.7836 19.5962L18.4701 17.9097C18.7584 17.6214 18.7584 17.1539 18.4701 16.8656C18.1818 16.5773 17.7144 16.5773 17.426 16.8656L16.9987 17.293L16.9902 4.69638L17.4305 5.13674Z" fill="currentColor"/> | ||
<path d="M20.2617 21.5C20.6695 21.5 21 21.1695 21 20.7617C21 20.354 20.6695 20.0234 20.2617 20.0234H12.2739C11.8662 20.0234 11.5356 20.354 11.5356 20.7617C11.5356 21.1695 11.8662 21.5 12.2739 21.5H20.2617Z" fill="currentColor"/> | ||
</svg> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is wrong, if so, please ignore this comment
When "vertical calibration" mode is on, if "align to surface" is disabled, it is possible to select objects (in 3d calibration, if the respective calibration mode is not active, objects cannot be selected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how it should be. Do you agree/disagree @sanmont3drepo?