Use relative links to extension reference pages #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| // @ts-check | |||
|
|
|||
| const gdevelopWikiUrlRoot = 'https://wiki.gdevelop.io/gdevelop5'; | |||
| const gdevelopWikiUrlRoot = '/gdevelop5'; | |||
There was a problem hiding this comment.
it's used in multiple scripts, are you sure it doesn't break the links?
There was a problem hiding this comment.
yes, it's the format we used when writing documentation.
There was a problem hiding this comment.
This is more a question asking if all the scripts using this will be safe. I think it's fine because it's all for generating wiki pages, so they should continue to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute links make navigation in the preview difficult because it links to the production.