Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative links to extension reference pages #5970

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Use relative links to extension reference pages #5970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion newIDE/app/scripts/lib/WikiHelpLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @ts-check

const gdevelopWikiUrlRoot = 'https://wiki.gdevelop.io/gdevelop5';
const gdevelopWikiUrlRoot = '/gdevelop5';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used in multiple scripts, are you sure it doesn't break the links?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's the format we used when writing documentation.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more a question asking if all the scripts using this will be safe. I think it's fine because it's all for generating wiki pages, so they should continue to work.

const improperlyFormattedHelpPaths = new Set();

/** @param {string} str */
Expand Down