Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prescription refresh workflow for image analysis handler #2230

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Add prescription refresh workflow for image analysis handler #2230

merged 5 commits into from
Jan 10, 2022

Conversation

pacospace
Copy link
Contributor

@pacospace pacospace commented Dec 22, 2021 •
edited
Loading

Signed-off-by: Francesco Murdaca [email protected]

Related-To: AICoE/recommend-base-image-tutorial#1
Fixes: #2229

@pacospace pacospace requested a review from fridex December 22, 2021 11:47
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2021
@sesheta sesheta requested review from goern and harshad16 December 22, 2021 11:47
@pacospace pacospace mentioned this pull request Dec 22, 2021
Open
12 tasks
@pacospace
Copy link
Contributor Author

/hold for testing

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2021
fridex
fridex approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍🏻 🥇

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2021
@pacospace pacospace force-pushed the add-new-prescription-refresh-workflow branch from 2a048b0 to 8e27446 Compare December 22, 2021 11:55
@pacospace
Copy link
Contributor Author

/retest

@goern
Copy link
Member

goern commented Jan 10, 2022

looks nice to me, can this go into next release?
/milestone 2022.01.18

@sesheta
Copy link
Member

sesheta commented Jan 10, 2022

@goern: The provided milestone is not valid for this repository. Milestones in this repository: [2022.01.17]

Use /milestone clear to clear the milestone.

In response to this:

looks nice to me, can this go into next release?
/milestone 2022.01.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@goern
Copy link
Member

goern commented Jan 10, 2022

/milestone 2022.01.17

@sesheta sesheta added this to the 2022.01.17 milestone Jan 10, 2022
split configmap into overlays
05e7e6e 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace mentioned this pull request Jan 10, 2022
Closed
@pacospace
Copy link
Contributor Author

/deploy

@pacospace pacospace force-pushed the add-new-prescription-refresh-workflow branch 3 times, most recently from 7cea037 to 9a66c0a Compare January 10, 2022 13:28
@pacospace pacospace mentioned this pull request Jan 10, 2022
Merged
@pacospace pacospace force-pushed the add-new-prescription-refresh-workflow branch from 9a66c0a to 1587afe Compare January 10, 2022 14:32
use dry run for testing first
c987aba 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the add-new-prescription-refresh-workflow branch from 1587afe to c987aba Compare January 10, 2022 14:57
harshad16
harshad16 requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just few minor chnages required.

prescriptions-refresh-job/overlays/ocp4-stage/imagestreamtag.yaml Outdated Show resolved Hide resolved
prescriptions-refresh-job/overlays/ocp4-stage/thoth-notification.yaml Outdated Show resolved Hide resolved
Francesco Murdaca and others added 2 commits January 10, 2022 15:59
@pacospace pacospace requested a review from harshad16 January 10, 2022 15:00
harshad16
harshad16 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
thanks 💯

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@sesheta
Copy link
Member

sesheta commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 5434a0b into thoth-station:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@fridex fridex fridex approved these changes

@goern goern Awaiting requested review from goern

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2022.01.17
Development

Successfully merging this pull request may close these issues.

Provide new workflow for prescription refresh in thoth-application for image analysis handler
5 participants
@pacospace @goern @sesheta @fridex @harshad16