-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove density from the true SDC reaction system #2560
Conversation
note: VODE is commented out
this seems to work for the Newton solver at the moment. I still need to update the VODE solver. |
With these changes to the Newton solver, I still get the expected convergence for the 4th order bubble_convergence test:
|
this requires: AMReX-Astro/Microphysics#1338 |
the VODE solver code path works now too. I'll stop here in this PR. In a follow-on PR, I'll remove all the VODE stuff from Castro and instead have us directly use the Microphysics simplified-SDC update, since the mechanics are identical. |
I think that this is ready for review. We should first merge: then rerun the tests here. Note that by merging that Microphysics PR, we'll break true-SDC in the current code (but it wasn't actually correct with VODE anyway). Then this PR will fix it all up again. |
test suite run with these changes: |
okay, I think that this is all set for review now. Microphysics has been updated and the benchmarks have been updated too. The test suite shows the expected error around tolerance. |
PR summary
This makes the linear algebra basically the same as with simplified-SDC.
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate