Add close command #115
Add close command #115
Conversation
…ewing with view command
| } | ||
|
|
||
| /** | ||
| * Constructs a {@code CommandResult} with the specified {@code feedbackToUser}, | ||
| * and other fields set to their default value. | ||
| */ | ||
| public CommandResult(String feedbackToUser) { | ||
| this(feedbackToUser, false, false); | ||
| this(feedbackToUser, false, false, false, null); |
There was a problem hiding this comment.
Instead of using null as a place holder value, perhaps we could consider using a static constant EMPTY_PERSON to align with OOP principles?
There was a problem hiding this comment.
Adding on, you can place this EMPTY_PERSON or DEFAULT_PERSON value in CommandCommons class.
|
|
||
| // Add the tier-specific style class | ||
| String tier = person.getTier().toParsableString().toLowerCase(); | ||
| tierLabel.getStyleClass().add(tier + "-tier"); |
There was a problem hiding this comment.
Great idea of using the enum and appending -tier to get the corresponding strings!
| } else if (commandText.trim().toLowerCase().equals("close")) { | ||
| handleCloseCommand(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps to align with the same levels of abstraction, the boolean evaluations (trim().toLowerCase...) can be moved to command result (similar to how below it is commandResult.isShowHelp); and abstracted as isShowView
| } | ||
|
|
||
| /** | ||
| * Constructs a {@code CommandResult} with the specified {@code feedbackToUser}, | ||
| * and other fields set to their default value. | ||
| */ | ||
| public CommandResult(String feedbackToUser) { | ||
| this(feedbackToUser, false, false); | ||
| this(feedbackToUser, false, false, false, null); |
There was a problem hiding this comment.
Adding on, you can place this EMPTY_PERSON or DEFAULT_PERSON value in CommandCommons class.
|
|
||
| public static final String COMMAND_WORD = "close"; | ||
|
|
||
| public static final String MESSAGE_SUCCESS = "Detail view closed."; |
There was a problem hiding this comment.
Perhaps this should be changed to Detailed view closed.
| public void execute_close_success() { | ||
| CloseCommand closeCommand = new CloseCommand(); | ||
| CommandResult commandResult = closeCommand.execute(model); | ||
|
|
||
| assertEquals(CloseCommand.MESSAGE_SUCCESS, commandResult.getFeedbackToUser()); | ||
| assertFalse(commandResult.isShowHelp()); | ||
| assertFalse(commandResult.isExit()); | ||
| } |
There was a problem hiding this comment.
Perhaps you can add one more test to check if when close is used when the detailed panel is not shown, that nothing happens?
There was a problem hiding this comment.
Testing on GUI quite a big change, have opened a new issue to further add that #120
…user-guide Rewrite of User Guide
…nfirmation Implement confirmation check
Co-authored-by: leyew <[email protected]>
Co-authored-by: leyew <[email protected]>
…r/add-view-and-close-command Add view command
…d-close-split-command # Conflicts: # src/main/java/seedu/address/logic/commands/CloseCommand.java # src/main/java/seedu/address/logic/commands/HelpCommand.java # src/main/java/seedu/address/ui/MainWindow.java # src/test/java/seedu/address/logic/commands/CommandResultTest.java # src/test/java/seedu/address/logic/commands/HelpCommandTest.java
iamdiluxedbutcooler
merged commit 9074ba2
into
AY2425S1-CS2103T-T14-4:master
closes #113
closecommand to close the split viewplease focus on changes in the 4 latest commits (after fixing EOF 2)