Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close command #115

Merged
merged 48 commits into from
Oct 22, 2024
Merged

Add close command #115

merged 48 commits into from
Oct 22, 2024

Commits on Oct 20, 2024

  1. Move saving data section to the last feature

    @itsme-zeix
    itsme-zeix committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    cf66436 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Update fork

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d03c915 View commit details
    Browse the repository at this point in the history

  2. Update fork 2

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c0cd395 View commit details
    Browse the repository at this point in the history

  3. Implement confirmation check

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e38f1f5 View commit details
    Browse the repository at this point in the history

  4. Refactor command logic

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1876f0d View commit details
    Browse the repository at this point in the history

  5. Fix saving bug

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c9bf45f View commit details
    Browse the repository at this point in the history

  6. Fix checkstyle violation

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3eec0ea View commit details
    Browse the repository at this point in the history

  7. Add test for delete command

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7d77a32 View commit details
    Browse the repository at this point in the history

  8. Fix import order

    @FionaQY
    FionaQY committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    97c0dcf View commit details
    Browse the repository at this point in the history

  9. Rewrite of User Guide

    @itsme-zeix
    itsme-zeix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8044291 View commit details
    Browse the repository at this point in the history

  10. Add Prerequisite section and setup congrats message

    @itsme-zeix
    itsme-zeix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7430457 View commit details
    Browse the repository at this point in the history

  11. Add view command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c3aac31 View commit details
    Browse the repository at this point in the history

  12. Add view command parser

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2bb50ac View commit details
    Browse the repository at this point in the history

  13. Update parser related file

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b414167 View commit details
    Browse the repository at this point in the history

  14. Refactor command classes as we going to define which person we are vi… 

    …ewing with view command
    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0e84a17 View commit details
    Browse the repository at this point in the history

  15. Update command result to include view command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4c4ea3 View commit details
    Browse the repository at this point in the history

  16. Update model classes

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0e89fdd View commit details
    Browse the repository at this point in the history

  17. Add split screen panel

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9cb5b26 View commit details
    Browse the repository at this point in the history

  18. Link new panel with main window

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    86e9eeb View commit details
    Browse the repository at this point in the history

  19. Update styling files

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0995698 View commit details
    Browse the repository at this point in the history

  20. Update arguments for view person in related tests

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9c504ce View commit details
    Browse the repository at this point in the history

  21. Add tests for view command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    294b216 View commit details
    Browse the repository at this point in the history

  22. Formatting main

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2ff0865 View commit details
    Browse the repository at this point in the history

  23. Formatting test

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b94e5d0 View commit details
    Browse the repository at this point in the history

  24. Fix EOF errors

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    75ada68 View commit details
    Browse the repository at this point in the history

  25. Fix EOF 2

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3437adf View commit details
    Browse the repository at this point in the history

  26. Add close command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f674e9a View commit details
    Browse the repository at this point in the history

  27. Update parser

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    26c58ee View commit details
    Browse the repository at this point in the history

  28. Update UI

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9623c34 View commit details
    Browse the repository at this point in the history

  29. Add test for close command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b5db425 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Add suggested changes

    @itsme-zeix
    itsme-zeix committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cd4f994 View commit details
    Browse the repository at this point in the history

  2. Merge pull request AY2425S1-CS2103T-T14-4#111 from itsme-zeix/update-… 

    …user-guide

Rewrite of User Guide
    @itsme-zeix
    itsme-zeix authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bc994c2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request AY2425S1-CS2103T-T14-4#107 from FionaQY/command-co… 

    …nfirmation

Implement confirmation check
    @ZShunRen
    ZShunRen authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    055ee03 View commit details
    Browse the repository at this point in the history

  4. Update src/main/java/seedu/address/model/ModelManager.java 

    Co-authored-by: leyew <[email protected]>
    @iamdiluxedbutcooler @itsme-zeix
    iamdiluxedbutcooler and itsme-zeix authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    63e59c8 View commit details
    Browse the repository at this point in the history

  5. Update src/main/java/seedu/address/model/ModelManager.java 

    Co-authored-by: leyew <[email protected]>
    @iamdiluxedbutcooler @itsme-zeix
    iamdiluxedbutcooler and itsme-zeix authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    261223e View commit details
    Browse the repository at this point in the history

  6. Change checking protocol to match other module

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    658be23 View commit details
    Browse the repository at this point in the history

  7. Standardize conditions

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1fb90af View commit details
    Browse the repository at this point in the history

  8. Resolve merge conflicts

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d641c02 View commit details
    Browse the repository at this point in the history

  9. Solve test fail

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6a3dcca View commit details
    Browse the repository at this point in the history

  10. Add enums for empty person

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    922f676 View commit details
    Browse the repository at this point in the history

  11. Merge pull request AY2425S1-CS2103T-T14-4#114 from iamdiluxedbutcoole… 

    …r/add-view-and-close-command

Add view command
    @iamdiluxedbutcooler
    iamdiluxedbutcooler authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8ca6273 View commit details
    Browse the repository at this point in the history

  12. Add close command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3dcac3e View commit details
    Browse the repository at this point in the history

  13. Update parser

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6b6523b View commit details
    Browse the repository at this point in the history

  14. Update UI

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    483fd7e View commit details
    Browse the repository at this point in the history

  15. Add test for close command

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7c2b2d0 View commit details
    Browse the repository at this point in the history

  16. Resolve merge conflict

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0a0167c View commit details
    Browse the repository at this point in the history

  17. Fix same level of abstraction

    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    91b5ded View commit details
    Browse the repository at this point in the history

  18. Merge remote-tracking branch 'origin/add-close-split-command' into ad… 

    …d-close-split-command

# Conflicts:
#	src/main/java/seedu/address/logic/commands/CloseCommand.java
#	src/main/java/seedu/address/logic/commands/HelpCommand.java
#	src/main/java/seedu/address/ui/MainWindow.java
#	src/test/java/seedu/address/logic/commands/CommandResultTest.java
#	src/test/java/seedu/address/logic/commands/HelpCommandTest.java
    @iamdiluxedbutcooler
    iamdiluxedbutcooler committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    62fb739 View commit details
    Browse the repository at this point in the history