Update CommandBar UI, ResultDisplay UI & default window size #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fine-command-bar-ui
…fine-command-bar-ui
itsme-zeix
requested review from
iamdiluxedbutcooler,
FionaQY,
ZShunRen and
colinhia
FionaQY
approved these changes
Oct 23, 2024
colinhia
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks for the hardwork in extracting out the files for easier maintainability!
| if (commandTextArea.getStyleClass().contains(ERROR_STYLE_CLASS)) { | ||
| return; | ||
| } | ||
| commandTextArea.setStyle("-fx-text-fill: grey;"); | ||
| } |
There was a problem hiding this comment.
Good use of abstraction and alignment to the pre-existing setStyleToDefault method!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command bar selected (Default):
Command bar unselected:
Command Error:
Do you guys think I should remove the prompt text `Enter command here...' when the command bar is selected? Currently the behaviour only changes the icon and prompt text to be lighter.
Closes #101.