forked from nus-cs2103-AY2425S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CommandBar UI, ResultDisplay UI & default window size #124
Merged
itsme-zeix
merged 16 commits into
AY2425S1-CS2103T-T14-4:master
from
itsme-zeix:refine-command-bar-ui
Oct 23, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e1f964c
Move css files into dedicated folder
itsme-zeix fd97250
Change color/UI behaviour of CommandBox and refactor for modularity
itsme-zeix be7c627
Change text color logic based on state of command box
itsme-zeix 8a247bc
Update ResultDisplay UI
itsme-zeix 423f0ed
Remove redundant new lines in DarkTheme.css
itsme-zeix d44d601
Remove unused import in CommandBox
itsme-zeix 6c21607
Merge branch 'master' of github.com:AY2425S1-CS2103T-T14-4/tp into re…
itsme-zeix 02bc667
Update default window size
itsme-zeix 7f928ad
Merge branch 'master' of github.com:AY2425S1-CS2103T-T14-4/tp into re…
itsme-zeix 0c18746
Fix merge conflict
itsme-zeix e611f03
Fix grey border around scrollpane of command bar
itsme-zeix 32b4336
Fix green border
itsme-zeix dfeef42
Fix spreadsheet url for commandbox
itsme-zeix 5c16d1d
Fix import order
itsme-zeix b1ec5f1
Fix style issues
itsme-zeix 7dbe194
Fix merge conflicts
itsme-zeix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,20 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
|
||
<?import java.net.URL?> | ||
<?import javafx.scene.control.TextField?> | ||
<?import javafx.scene.control.TextArea?> | ||
<?import javafx.scene.layout.HBox?> | ||
<?import javafx.scene.layout.StackPane?> | ||
|
||
<StackPane styleClass="stack-pane" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1"> | ||
<?import org.kordamp.ikonli.javafx.FontIcon?> | ||
|
||
<StackPane styleClass="stack-panel" xmlns="http://javafx.com/javafx/22" xmlns:fx="http://javafx.com/fxml/1"> | ||
<stylesheets> | ||
<URL value="@DarkTheme.css" /> | ||
<URL value="@/view/css/CommandBox.css" /> | ||
</stylesheets> | ||
<TextArea fx:id="commandTextArea" promptText="Enter command here..." wrapText="true" maxHeight="200"/> | ||
</StackPane> | ||
|
||
<HBox fx:id="commandTextContainer" alignment="CENTER_LEFT" spacing="5" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml"> | ||
<FontIcon fx:id="commandTextIcon" iconLiteral="fas-terminal"/> | ||
<TextArea fx:id="commandTextArea" maxHeight="200" promptText="Enter command here..." wrapText="true" HBox.hgrow="ALWAYS" /> | ||
</HBox> | ||
|
||
</StackPane> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,14 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
|
||
<?import java.net.URL?> | ||
|
||
<?import javafx.scene.control.TextArea?> | ||
<?import javafx.scene.layout.StackPane?> | ||
|
||
<StackPane fx:id="placeHolder" styleClass="pane-with-border" xmlns="http://javafx.com/javafx/17" | ||
xmlns:fx="http://javafx.com/fxml/1"> | ||
<TextArea fx:id="resultDisplay" editable="false" styleClass="result-display"/> | ||
<StackPane styleClass="stack-pane" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1"> | ||
<stylesheets> | ||
<URL value="@css/ResultDisplay.css" /> | ||
</stylesheets> | ||
|
||
<TextArea fx:id="resultDisplay" editable="false" styleClass="result-display" wrapText="true"/> | ||
</StackPane> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
#commandTextContainer { | ||
-fx-background-color: #1C1C1C; | ||
-fx-border-color: #1C1C1C; | ||
-fx-border-width: 1px; | ||
|
||
-fx-padding: 10 15 10 15; | ||
|
||
-fx-pref-height: 50px; | ||
-fx-min-height: 50px; | ||
-fx-max-height: 50px; | ||
} | ||
|
||
#commandTextIcon { | ||
-fx-icon-size: 15; | ||
-fx-icon-color: white; | ||
} | ||
|
||
#commandTextArea { | ||
|
||
-fx-background-color: #1C1C1C; | ||
-fx-control-inner-background: #1C1C1C; | ||
|
||
-fx-font-family: "Jetbrains Mono"; | ||
-fx-font-size: 13pt; | ||
-fx-prompt-text-fill: #656565; | ||
-fx-text-fill: white; | ||
|
||
-fx-pref-height: 35px; | ||
-fx-max-height: 35px; | ||
-fx-min-height: 35px; | ||
-fx-padding: 0 0 0 -5px; | ||
|
||
-fx-border-width: 0; | ||
|
||
} | ||
|
||
#commandTextArea .content { | ||
-fx-background-radius: 0; | ||
-fx-background-color: #1C1C1C; | ||
-fx-border-width: 0; | ||
} | ||
|
||
#commandTextArea .viewport { | ||
-fx-background-color: #1C1C1C; | ||
-fx-border-width: 0; | ||
} | ||
|
||
#commandTextArea:focused { | ||
-fx-prompt-text-fill: grey; | ||
-fx-border-width: 0; | ||
} | ||
|
||
.scroll-pane { | ||
-fx-background-color: transparent; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the hardwork in extracting out the files for easier maintainability! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
.result-display { | ||
-fx-background-color: #1C1C1C; | ||
-fx-control-inner-background: #1C1C1C; | ||
-fx-highlight-text-fill: #1C1C1C; | ||
-fx-faint-focus-color: #1C1C1C; | ||
-fx-font-family: "Segoe UI Light"; | ||
-fx-font-size: 13pt; | ||
-fx-text-fill: white; | ||
} | ||
|
||
#resultDisplay .content { | ||
-fx-background-color: #1C1C1C, #1C1C1C, #1C1C1C, #1C1C1C; | ||
-fx-background-radius: 0; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of abstraction and alignment to the pre-existing setStyleToDefault method!