#13173 - fixing DCA for combined tracking + adding nshared clusters

[miranov25]

Relates to:
#12928

Should fix -not yet fully
#13173

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted
async-2024-pp-apass1
async-2024-pp-apass1-accepted
async-2022-pp-apass7
async-2022-pp-apass7-accepted
async-2024-pp-cpass0
async-2024-pp-cpass0-accepted

[miranov25]

• getting shared clusters - more complicated than in the Run1, Run2, not clear if possible without device input modification

Laura Serksnyte
11:33 AM

hi Marian, I am not sure how you make your skimmed data; I wrote the code for shared cluster QC in the the framework; i can send you the tasks

Jens helped me with this task so I am not sure there is some better way to do it

AliceO2/Detectors/TPC/qc/src/TrackClusters.cxx

Line 61 in 5b5abc2

bool TrackClusters::processTrackAndClusters(const std::vector<o2::tpc::TrackTPC>* tracks, const o2::tpc::ClusterNativeAccess* clusterIndex, std::vector<o2::tpc::TPCClRefElem>* clusRefs)

[miranov25]

In the figure below, the DCA for combined tracks after the bug fix is displayed. Previously, modulation was observed and the DCA had to be adjusted for vertex_x and vertex_y using the formula:

tree->SetAlias("dcar_itstpc0","dcar_itstpc+sin(phi)*vertex_x+cos(phi)*vertex_y");

In earlier performance parameterizations for DCA resolution and bias, I corrected for mismatches by applying a vertex_x and vertex_y correction as a first-order approximation. However, it is preferable to compute the DCA properly, as second-order effects were influencing precision.

[davidrohr]

@miranov25 : please run clang format, so that we can merge it

[miranov25]

I did not make modification in O2 for some time, I forgot how I made that clang-format check. Last time somebody provided me the command, but I did. not have it in my history anymore.
Which style do we use?

Or do we use the default one?

[davidrohr]

The style file comes with O2
You can use the git-clang-format command, to format only your changes correctly.
Also, in the PR checker list above, you can check the Formatting / PR formatting / clang-format check to see what is wrong.

[miranov25]

+async-label async-2022-pp-apass4, async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2022-pp-apass6 2023-PbPb-apass2, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7, async-2024-pp-cpass0

[github-actions]

Hi @miranov25, the following label names could not be recognised: async-2022-pp-apass6 2023-PbPb-apass2

[benedikt-voelkel]

Thanks for labelling @miranov25 .
I already took care of adding the missing label. Maybe there was a typo. Anyway, it's there now.

[chiarazampolli]

Cherry-picking to async-2022-pp-apass4 does not work. Since apass4 is deprecated, I remove the label.

[chiarazampolli]

Same for apass6 pp 2022 and PbPb 2023 apass2.