feat: add computer memory units and memoryvalue #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@saskiad You're right that python enum conventions are to have capital letters, so I removed bit for now (it probably wasn't going to get used anyways) and capitalized KB. I think you can merge this now |
Sun-flow
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Looks in line with the rest of our units with value. Saskia should confirm that this is intended implementation.
Fyi, you can write closes #ticket_number in the PR description in order to link a ticket to a PR. This will also close the ticket when the PR is merged.
saskiad
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.